From: Tejun Heo <tj@kernel.org>
To: Matthew Wilcox <mawilcox@microsoft.com>,
Chris Wilson <chris@chris-wilson.co.uk>
Cc: David Airlie <airlied@linux.ie>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-next@vger.kernel.org, sachinp <sachinp@linux.vnet.ibm.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Abdul Haleem <abdhalee@linux.vnet.ibm.com>
Subject: Re: [next-20170609] WARNING: CPU: 3 PID: 71167 at lib/idr.c:157 idr_replace
Date: Thu, 22 Jun 2017 14:58:37 -0400 [thread overview]
Message-ID: <20170622185837.GD18600@htj.duckdns.org> (raw)
In-Reply-To: <149808789548.17054.471609626305557642@mail.alporthouse.com>
On Thu, Jun 22, 2017 at 12:31:35AM +0100, Chris Wilson wrote:
> Quoting Tejun Heo (2017-06-13 14:58:49)
> > Cc'ing David Airlie.
> >
> > This is from drm driver calling in idr_replace() w/ a negative id.
> > Probably a silly bug in error handling path?
>
> No, this is the validation of an invalid userspace handle. The drm ABI
> for handles is supposed to be a full u32 range with 0 reserved for an
> invalid handle (constrained by the idr_alloc ofc). The WARN was
> introduced by 0a835c4f090a.
Matthew, did idr lost some of its range while being reimplemented
using radix tree?
Thanks.
--
tejun
prev parent reply other threads:[~2017-06-22 18:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 14:40 [next-20170609] WARNING: CPU: 3 PID: 71167 at lib/idr.c:157 idr_replace Abdul Haleem
2017-06-13 13:58 ` Tejun Heo
2017-06-21 22:49 ` Dave Airlie
2017-06-21 23:31 ` Chris Wilson
2017-06-22 18:58 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170622185837.GD18600@htj.duckdns.org \
--to=tj@kernel.org \
--cc=abdhalee@linux.vnet.ibm.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mawilcox@microsoft.com \
--cc=sachinp@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).