From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net (shards.monkeyblade.net [184.105.139.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3wz9Gw1WCwzDr57 for ; Fri, 30 Jun 2017 05:49:43 +1000 (AEST) Date: Thu, 29 Jun 2017 15:49:37 -0400 (EDT) Message-Id: <20170629.154937.1428574116488487036.davem@davemloft.net> To: arvind.yadav.cs@gmail.com Cc: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, tlfalcon@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ibm: ibmveth: constify dev_pm_ops structures. From: David Miller In-Reply-To: <24303710c4e099faa0ca7d9d92a71e53d6b66bcc.1498714986.git.arvind.yadav.cs@gmail.com> References: <24303710c4e099faa0ca7d9d92a71e53d6b66bcc.1498714986.git.arvind.yadav.cs@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Arvind Yadav Date: Thu, 29 Jun 2017 11:14:50 +0530 > dev_pm_ops are not supposed to change at runtime. All functions > working with dev_pm_ops provided by work with const > dev_pm_ops. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 15426 1256 0 16682 412a drivers/net/ethernet/ibm/ibmveth.o > > File size After adding 'const': > text data bss dec hex filename > 15618 1064 0 16682 412a drivers/net/ethernet/ibm/ibmveth.o > > Signed-off-by: Arvind Yadav Applied.