* [PATCH] powerpc/hugetlbfs: Export HPAGE_SHIFT
@ 2017-06-30 6:52 Oliver O'Halloran
2017-06-30 9:28 ` Anshuman Khandual
2017-07-02 11:01 ` Michael Ellerman
0 siblings, 2 replies; 4+ messages in thread
From: Oliver O'Halloran @ 2017-06-30 6:52 UTC (permalink / raw)
To: linuxppc-dev; +Cc: mpe, Oliver O'Halloran
Export it so it can be referenced inside a module.
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
---
arch/powerpc/mm/hugetlbpage.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
index ceeab69cf7fc..96293560f294 100644
--- a/arch/powerpc/mm/hugetlbpage.c
+++ b/arch/powerpc/mm/hugetlbpage.c
@@ -34,6 +34,7 @@
#define PAGE_SHIFT_16G 34
unsigned int HPAGE_SHIFT;
+EXPORT_SYMBOL(HPAGE_SHIFT);
/*
* Tracks gpages after the device tree is scanned and before the
--
2.9.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/hugetlbfs: Export HPAGE_SHIFT
2017-06-30 6:52 [PATCH] powerpc/hugetlbfs: Export HPAGE_SHIFT Oliver O'Halloran
@ 2017-06-30 9:28 ` Anshuman Khandual
2017-07-03 3:36 ` Oliver
2017-07-02 11:01 ` Michael Ellerman
1 sibling, 1 reply; 4+ messages in thread
From: Anshuman Khandual @ 2017-06-30 9:28 UTC (permalink / raw)
To: Oliver O'Halloran, linuxppc-dev
On 06/30/2017 12:22 PM, Oliver O'Halloran wrote:
> Export it so it can be referenced inside a module.
>
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
> ---
> arch/powerpc/mm/hugetlbpage.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
> index ceeab69cf7fc..96293560f294 100644
> --- a/arch/powerpc/mm/hugetlbpage.c
> +++ b/arch/powerpc/mm/hugetlbpage.c
> @@ -34,6 +34,7 @@
> #define PAGE_SHIFT_16G 34
>
> unsigned int HPAGE_SHIFT;
> +EXPORT_SYMBOL(HPAGE_SHIFT);
Why would you need this in a driver ? This represents the
default HugeTLB page size.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/hugetlbfs: Export HPAGE_SHIFT
2017-06-30 9:28 ` Anshuman Khandual
@ 2017-07-03 3:36 ` Oliver
0 siblings, 0 replies; 4+ messages in thread
From: Oliver @ 2017-07-03 3:36 UTC (permalink / raw)
To: Anshuman Khandual; +Cc: linuxppc-dev
On Fri, Jun 30, 2017 at 7:28 PM, Anshuman Khandual
<khandual@linux.vnet.ibm.com> wrote:
> On 06/30/2017 12:22 PM, Oliver O'Halloran wrote:
>> Export it so it can be referenced inside a module.
>>
>> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
>> ---
>> arch/powerpc/mm/hugetlbpage.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
>> index ceeab69cf7fc..96293560f294 100644
>> --- a/arch/powerpc/mm/hugetlbpage.c
>> +++ b/arch/powerpc/mm/hugetlbpage.c
>> @@ -34,6 +34,7 @@
>> #define PAGE_SHIFT_16G 34
>>
>> unsigned int HPAGE_SHIFT;
>> +EXPORT_SYMBOL(HPAGE_SHIFT);
>
> Why would you need this in a driver ? This represents the
> default HugeTLB page size.
Libnvdimm uses HPAGE_SIZE for a few things that it probably shouldn't.
I have sent a fix for libnvdimm, but that hasn't been merged yet and
this was breaking mpe's -next builds in the mean time. I agree it's
kind of bad, but we needed ZONE_DEVICE support to be in 4.13.
Oliver
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: powerpc/hugetlbfs: Export HPAGE_SHIFT
2017-06-30 6:52 [PATCH] powerpc/hugetlbfs: Export HPAGE_SHIFT Oliver O'Halloran
2017-06-30 9:28 ` Anshuman Khandual
@ 2017-07-02 11:01 ` Michael Ellerman
1 sibling, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2017-07-02 11:01 UTC (permalink / raw)
To: Oliver O'Halloran, linuxppc-dev; +Cc: Oliver O'Halloran
On Fri, 2017-06-30 at 06:52:35 UTC, Oliver O'Halloran wrote:
> Export it so it can be referenced inside a module.
>
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/7a849a6cf3ff676d1726259c18fa41
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-03 3:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-30 6:52 [PATCH] powerpc/hugetlbfs: Export HPAGE_SHIFT Oliver O'Halloran
2017-06-30 9:28 ` Anshuman Khandual
2017-07-03 3:36 ` Oliver
2017-07-02 11:01 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).