From: Brian Norris <computersforpeace@gmail.com>
To: Cyril Bur <cyrilbur@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-mtd@lists.infradead.org,
stewart@linux.vnet.ibm.com, dwmw2@infradead.org
Subject: Re: [PATCH 5/5] mtd: powernv_flash: Use opal_async_wait_response_interruptible()
Date: Fri, 7 Jul 2017 18:28:11 -0700 [thread overview]
Message-ID: <20170708012811.GF55942@google.com> (raw)
In-Reply-To: <20170629065413.19845-6-cyrilbur@gmail.com>
On Thu, Jun 29, 2017 at 04:54:13PM +1000, Cyril Bur wrote:
> The OPAL calls performed in this driver shouldn't be using
> opal_async_wait_response() as this performs a wait_event() which, on
> long running OPAL calls could result in hung task warnings. wait_event()
> also prevents timely signal delivery which is also undesirable.
>
> This patch also attempts to quieten down the use of dev_err() when
> errors haven't actually occurred and also to return better information up
> the stack rather than always -EIO.
>
> Signed-off-by: Cyril Bur <cyrilbur@gmail.com>
> ---
> drivers/mtd/devices/powernv_flash.c | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
Seems OK:
Acked-by: Brian Norris <computersforpeace@gmail.com>
next prev parent reply other threads:[~2017-07-08 1:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 6:54 [PATCH 0/5] Allow opal-async waiters to get interrupted Cyril Bur
2017-06-29 6:54 ` [PATCH 1/5] powerpc/opal: Make __opal_async_{get, release}_token() static Cyril Bur
2017-06-29 6:54 ` [PATCH 2/5] powerpc/opal: Rework the opal-async interface Cyril Bur
2017-06-29 6:54 ` [PATCH 3/5] powerpc/opal: Add opal_async_wait_response_interruptible() to opal-async Cyril Bur
2017-06-29 6:54 ` [PATCH 4/5] powerpc/powernv: Add OPAL_BUSY to opal_error_code() Cyril Bur
2017-06-29 6:54 ` [PATCH 5/5] mtd: powernv_flash: Use opal_async_wait_response_interruptible() Cyril Bur
2017-07-08 1:28 ` Brian Norris [this message]
2017-07-08 19:59 ` Benjamin Herrenschmidt
2017-07-09 23:58 ` Cyril Bur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170708012811.GF55942@google.com \
--to=computersforpeace@gmail.com \
--cc=cyrilbur@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=stewart@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).