From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3x5cKG5Sx3zDq6W for ; Mon, 10 Jul 2017 17:29:06 +1000 (AEST) From: Sebastian Huber To: netdev@vger.kernel.org Cc: Madalin Bucur , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] soc/qbman: Simplify bman_release() Date: Mon, 10 Jul 2017 09:28:59 +0200 Message-Id: <20170710072859.2616-1-sebastian.huber@embedded-brains.de> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Get the affine portal only once for the complete transaction. Signed-off-by: Sebastian Huber --- drivers/soc/fsl/qbman/bman.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/soc/fsl/qbman/bman.c b/drivers/soc/fsl/qbman/bman.c index a3d6d7cfa929..0af2069a6b7e 100644 --- a/drivers/soc/fsl/qbman/bman.c +++ b/drivers/soc/fsl/qbman/bman.c @@ -723,26 +723,23 @@ int bman_release(struct bman_pool *pool, const struct bm_buffer *bufs, u8 num) DPAA_ASSERT(num > 0 && num <= 8); - do { + while (1) { p = get_affine_portal(); local_irq_save(irqflags); avail = bm_rcr_get_avail(&p->p); if (avail < 2) update_rcr_ci(p, avail); r = bm_rcr_start(&p->p); - local_irq_restore(irqflags); - put_affine_portal(); if (likely(r)) break; + local_irq_restore(irqflags); + put_affine_portal(); + if (unlikely(--timeout == 0)) + return -ETIMEDOUT; udelay(1); - } while (--timeout); - - if (unlikely(!timeout)) - return -ETIMEDOUT; + } - p = get_affine_portal(); - local_irq_save(irqflags); /* * we can copy all but the first entry, as this can trigger badness * with the valid-bit -- 2.12.3