From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Jiri Olsa <jolsa@redhat.com>,
Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
Andi Kleen <andi@firstfloor.org>,
ak@linux.intel.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, mikey@neuling.org,
mpetlan@redhat.com
Subject: Re: [GIT PULL] Please pull JSON files for Power9 PMU events
Date: Wed, 12 Jul 2017 09:40:08 -0700 [thread overview]
Message-ID: <20170712164008.GC31223@us.ibm.com> (raw)
In-Reply-To: <20170712144611.GN27350@kernel.org>
Arnaldo Carvalho de Melo [acme@kernel.org] wrote:
> Em Wed, Jul 12, 2017 at 10:09:12PM +1000, Michael Ellerman escreveu:
> > Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> writes:
> > > Please pull the JSON files for POWER9 PMU events.
>
> > > perf vendor events: Add POWER9 PMU events
> > > perf vendor events: Add POWER9 PVRs to mapfile
>
> > I think the PVRs need work.
>
> > You have:
>
> > +004e0100,1,power9.json,core
> > +004e0000,1,power9.json,core
>
> > The first is P9 DD1, but the second doesn't exist. We have it in the
> > kernel, but with a mask of 0xffff0000. From memory the perf code doesn't
> > do any masking or anything fancy, it looks for an exact match.
>
> > So for starters you should probably drop that one and add 0x004e1200 and
> > 0x004e0200.
Yes, thanks.
>
> Could this check be somehow done automatically? Using whatever is in the
> kernel sources or some IBM released document?
Yes, had a recent discussion offline with Michael Petlan and Jiri about
generalizing/simplifying this. For now, I have added the above PVRs and
will look into the broader fix.
The following changes since commit 07d306c838c5c30196619baae36107d0615e459b:
Merge git://www.linux-watchdog.org/linux-watchdog (2017-07-11 09:59:37 -0700)
are available in the git repository at:
https://github.com/sukadev/linux/ p9-json
for you to fetch changes up to 8870b54739866c6eea23c36a0125af8045fbd572:
perf vendor events: Add POWER9 PVRs to mapfile (2017-07-12 11:11:00 -0500)
----------------------------------------------------------------
Sukadev Bhattiprolu (2):
perf vendor events: Add POWER9 PMU events
perf vendor events: Add POWER9 PVRs to mapfile
tools/perf/pmu-events/arch/powerpc/mapfile.csv | 3 +
.../perf/pmu-events/arch/powerpc/power9/cache.json | 176 +++++
.../arch/powerpc/power9/floating-point.json | 44 ++
.../pmu-events/arch/powerpc/power9/frontend.json | 446 +++++++++++
.../pmu-events/arch/powerpc/power9/marked.json | 782 +++++++++++++++++++
.../pmu-events/arch/powerpc/power9/memory.json | 158 ++++
.../perf/pmu-events/arch/powerpc/power9/other.json | 836 +++++++++++++++++++++
.../pmu-events/arch/powerpc/power9/pipeline.json | 680 +++++++++++++++++
tools/perf/pmu-events/arch/powerpc/power9/pmc.json | 146 ++++
.../arch/powerpc/power9/translation.json | 272 +++++++
10 files changed, 3543 insertions(+)
create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/cache.json
create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/floating-point.json
create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/frontend.json
create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/marked.json
create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/memory.json
create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/other.json
create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/pipeline.json
create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/pmc.json
create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/translation.json
next prev parent reply other threads:[~2017-07-12 18:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 2:08 [GIT PULL] Please pull JSON files for Power9 PMU events Sukadev Bhattiprolu
2017-07-12 12:09 ` Michael Ellerman
2017-07-12 14:46 ` Arnaldo Carvalho de Melo
2017-07-12 16:40 ` Sukadev Bhattiprolu [this message]
2017-07-12 19:49 ` Arnaldo Carvalho de Melo
2017-07-13 3:43 ` Michael Ellerman
2017-07-13 8:09 ` Jiri Olsa
2017-07-13 9:50 ` Michael Ellerman
2017-07-13 3:42 ` Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2017-08-02 17:46 Sukadev Bhattiprolu
2017-08-02 18:35 ` Arnaldo Carvalho de Melo
2017-08-30 23:15 [GIT PULL] Please pull JSON files for POWER9 " Sukadev Bhattiprolu
2017-08-31 16:38 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170712164008.GC31223@us.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=mpetlan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).