From: Segher Boessenkool <segher@kernel.crashing.org>
To: Matt Brown <matthew.brown.dev@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, anton@samba.org
Subject: Re: [PATCH 5/5] powerpc/lib/sstep: Add isel instruction emulation
Date: Thu, 13 Jul 2017 02:47:32 -0500 [thread overview]
Message-ID: <20170713074732.GD13471@gate.crashing.org> (raw)
In-Reply-To: <20170713032548.451-5-matthew.brown.dev@gmail.com>
On Thu, Jul 13, 2017 at 01:25:48PM +1000, Matt Brown wrote:
> + case 585: /* isel */
The secondary opcode for isel is only 5 bits, not 10 like most other
insns have.
> + mb = (instr >> 6) & 0x1f; /* bc */
> + val = (regs->ccr >> (mb + 32)) & 1;
regs->ccr >> (31 - mb) ?
> +
> + if (val)
> + regs->gpr[rd] = regs->gpr[ra];
You need to treat ra=0 separately (as 0, not reg 0).
> + else
> + regs->gpr[rd] = regs->gpr[rb];
> + goto logical_done;
Segher
next prev parent reply other threads:[~2017-07-13 7:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 3:25 [PATCH 1/5] powerpc/lib/sstep: Add cmpb instruction emulation Matt Brown
2017-07-13 3:25 ` [PATCH 2/5] powerpc/lib/sstep: Add popcnt " Matt Brown
2017-07-13 3:25 ` [PATCH 3/5] powerpc/lib/sstep: Add bpermd " Matt Brown
2017-07-13 7:16 ` Gabriel Paubert
2017-07-13 7:28 ` Segher Boessenkool
2017-07-14 4:19 ` Matt Brown
2017-07-14 16:17 ` Segher Boessenkool
2017-07-13 3:25 ` [PATCH 4/5] powerpc/lib/sstep: Add prty " Matt Brown
2017-07-13 7:37 ` Segher Boessenkool
2017-07-14 0:46 ` Matt Brown
2017-07-14 19:02 ` kbuild test robot
2017-07-13 3:25 ` [PATCH 5/5] powerpc/lib/sstep: Add isel " Matt Brown
2017-07-13 7:47 ` Segher Boessenkool [this message]
2017-07-14 0:49 ` Matt Brown
2017-07-13 3:51 ` [PATCH 1/5] powerpc/lib/sstep: Add cmpb " Andrew Donnellan
2017-07-13 6:43 ` Segher Boessenkool
2017-07-13 7:10 ` Segher Boessenkool
2017-07-13 6:46 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713074732.GD13471@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=anton@samba.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matthew.brown.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).