From: Lukas Wunner <lukas@wunner.de>
To: Daniel Axtens <dja@axtens.net>
Cc: linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, benh@kernel.crashing.org,
z.liuxinliang@hisilicon.com, zourongrong@gmail.com,
catalin.marinas@arm.com, will.deacon@arm.com,
gabriele.paoloni@huawei.com, bhelgaas@google.com,
airlied@linux.ie, daniel.vetter@intel.com,
alex.williamson@redhat.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/3] Split VGA default device handler out of VGA arbiter
Date: Sat, 5 Aug 2017 08:57:54 +0200 [thread overview]
Message-ID: <20170805065754.GA8509@wunner.de> (raw)
In-Reply-To: <20170804102033.27731-3-dja@axtens.net>
On Fri, Aug 04, 2017 at 08:20:32PM +1000, Daniel Axtens wrote:
> A system without PCI legacy resources (e.g. ARM64, powerpc) may
> find that no default/boot VGA device has been marked, because the
> VGA arbiter checks for legacy resource decoding before marking a
> card as default.
Would it be feasible to just sprinkle some "if (IS_ENABLED(CONFIG_X86))"
over the portions of vgaarb.c that deal with legacy resources?
I'm missing some context as to the negative consequences you're
experiencing on other arches (the cover letter merely refers to
"quirks in ppc and concerns in arm land" and is missing links to
archived versions of v1 and v2), but clearly legacy resources are
x86-specific so any code dealing with them seems superfluous on
other arches and should be marked as such.
Please cc dri-devel when proposing changes to vgaarb.c (see
MAINTAINERS).
Thanks,
Lukas
next prev parent reply other threads:[~2017-08-05 7:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 10:20 [PATCH 0/3] Split VGA default selection from VGA arbiter Daniel Axtens
2017-08-04 10:20 ` [PATCH 1/3] powerpc: simplify and fix VGA default device behaviour Daniel Axtens
2017-08-11 21:44 ` Bjorn Helgaas
2017-08-13 22:34 ` Daniel Axtens
2017-08-04 10:20 ` [PATCH 2/3] Split VGA default device handler out of VGA arbiter Daniel Axtens
2017-08-05 6:57 ` Lukas Wunner [this message]
2017-08-06 23:49 ` Daniel Axtens
2017-08-04 10:20 ` [PATCH 3/3] powerpc: replace vga_fixup() with generic code Daniel Axtens
2017-08-07 7:18 ` Michael Ellerman
2017-08-07 23:01 ` Daniel Axtens
2017-08-08 10:12 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170805065754.GA8509@wunner.de \
--to=lukas@wunner.de \
--cc=airlied@linux.ie \
--cc=alex.williamson@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.vetter@intel.com \
--cc=dja@axtens.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=gabriele.paoloni@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=will.deacon@arm.com \
--cc=z.liuxinliang@hisilicon.com \
--cc=zourongrong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).