From: Paul Mackerras <paulus@ozlabs.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Alexander Graf" <agraf@suse.com>,
"Scott Wood" <scottwood@freescale.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] KVM: PPC: e500: fix some NULL dereferences on error
Date: Thu, 31 Aug 2017 13:40:19 +1000 [thread overview]
Message-ID: <20170831034019.GA22549@fergus.ozlabs.ibm.com> (raw)
In-Reply-To: <20170713073829.dqjahnakxqvpne7x@mwanda>
On Thu, Jul 13, 2017 at 10:38:29AM +0300, Dan Carpenter wrote:
> There are some error paths in kvmppc_core_vcpu_create_e500() where we
> forget to set the error code. It means that we return ERR_PTR(0) which
> is NULL and it results in a NULL pointer dereference in the caller.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, both patches applied to my kvm-ppc-next branch.
Paul.
prev parent reply other threads:[~2017-08-31 3:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 7:38 [PATCH 1/2] KVM: PPC: e500: fix some NULL dereferences on error Dan Carpenter
2017-07-31 6:03 ` Paul Mackerras
2017-07-31 7:54 ` Dan Carpenter
2017-08-31 3:40 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831034019.GA22549@fergus.ozlabs.ibm.com \
--to=paulus@ozlabs.org \
--cc=agraf@suse.com \
--cc=benh@kernel.crashing.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).