From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: "Oliver O'Halloran" <oohall@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, mikey@neuling.org
Subject: Re: [PATCH 4/4] powerpc/smp: Add Power9 scheduler topology
Date: Thu, 31 Aug 2017 05:33:53 -0700 [thread overview]
Message-ID: <20170831123353.GA37619@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170629071256.8159-5-oohall@gmail.com>
> +static struct sched_domain_topology_level power9_topology[] = {
> +#ifdef CONFIG_SCHED_SMT
> + { cpu_smt_mask, powerpc_smt_flags, SD_INIT_NAME(SMT) },
> +#endif
> + { shared_cache_mask, powerpc_shared_cache_flags, SD_INIT_NAME(CACHE) },
> + { cpu_cpu_mask, SD_INIT_NAME(DIE) },
> + { NULL, },
> +};
> +
Should we name this domain as MC instead of CACHE. Then it would be
compatible with other archs like x86/arm/s390. MC stands for Multi-Core
so it gels with what we have.
Also we could enable CONFIG_SCHED_MC and reuse cpu_core_flags() instead
of adding powerpc_shared_cache_flags.
prev parent reply other threads:[~2017-08-31 12:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 7:12 power9 shared caches support Oliver O'Halloran
2017-06-29 7:12 ` [PATCH 1/4] powerpc/smp: Use cpu_to_chip_id() to find core siblings Oliver O'Halloran
2017-09-01 13:29 ` [1/4] " Michael Ellerman
2017-06-29 7:12 ` [PATCH 2/4] powerpc/smp: Rework CPU topology construction Oliver O'Halloran
2017-06-29 7:12 ` [PATCH 3/4] powerpc/smp: Add cpu_l2_cache_map Oliver O'Halloran
2017-06-29 7:12 ` [PATCH 4/4] powerpc/smp: Add Power9 scheduler topology Oliver O'Halloran
2017-08-31 7:30 ` Michael Ellerman
2017-08-31 12:33 ` Srikar Dronamraju [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831123353.GA37619@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).