From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>,
peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, namhyung@kernel.org,
jolsa@kernel.org, linux-kernel@vger.kernel.org,
mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2] perf test powerpc: Fix 'Object code reading' test
Date: Thu, 31 Aug 2017 13:31:46 -0300 [thread overview]
Message-ID: <20170831163146.GE4831@kernel.org> (raw)
In-Reply-To: <b1d6fc01-05ff-708c-a61a-b7cb6706ab8d@intel.com>
Em Thu, Aug 31, 2017 at 12:15:29PM +0300, Adrian Hunter escreveu:
> On 31/08/17 12:14, Ravi Bangoria wrote:
> > 'Object code reading' test always fails on powerpc guest. Two reasons
> > for the failure are:
> >
> > 1. When elf section is too big (size beyond 'unsigned int' max value).
> > objdump fails to disassemble from such section. This was fixed with
> > commit 0f6329bd7fc ("binutils/objdump: Fix disassemble for huge elf
> > sections") in binutils.
> >
> > 2. When the sample is from hypervisor. Hypervisor symbols can not
> > be resolved within guest and thus thread__find_addr_map() fails for
> > such symbols. Fix this by ignoring hypervisor symbols in the test.
> >
> > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Thanks, applied.
- Arnaldo
prev parent reply other threads:[~2017-08-31 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 9:14 [PATCH v2] perf test powerpc: Fix 'Object code reading' test Ravi Bangoria
2017-08-31 9:15 ` Adrian Hunter
2017-08-31 16:31 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831163146.GE4831@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).