From: Paul Mackerras <paulus@ozlabs.org>
To: Jose Ricardo Ziviani <joserz@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, agraf@suse.com, mpe@ellerman.id.au
Subject: Re: [PATCH RFC] KVM: PPC: Book3S: Add MMIO emulation for VMX instructions
Date: Fri, 1 Sep 2017 20:38:41 +1000 [thread overview]
Message-ID: <20170901103841.GA29876@fergus.ozlabs.ibm.com> (raw)
In-Reply-To: <1504045082-16178-2-git-send-email-joserz@linux.vnet.ibm.com>
On Tue, Aug 29, 2017 at 07:18:02PM -0300, Jose Ricardo Ziviani wrote:
> This patch provides the MMIO load/store vector indexed
> X-Form emulation.
>
> Instructions implemented: lvx, stvx
>
> Signed-off-by: Jose Ricardo Ziviani <joserz@linux.vnet.ibm.com>
Thanks for the patch. The basic outline of it looks fine. The parts
where you are accessing the VMX register image in memory are a bit
hard to follow, and I'll have to check them in detail.
Longer term, I want to switch over to using the instruction emulation
infrastructure in arch/powerpc/lib/sstep.c that I have recently
expanded to handle almost all load and store instructions. That will
reduce duplication and should simplify all of this code enormously.
Regards,
Paul.
next prev parent reply other threads:[~2017-09-01 10:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 22:18 [PATCH RFC] powerpc: Implements MMIO emulation for lvx/stvx instructions Jose Ricardo Ziviani
2017-08-29 22:18 ` [PATCH RFC] KVM: PPC: Book3S: Add MMIO emulation for VMX instructions Jose Ricardo Ziviani
2017-09-01 10:38 ` Paul Mackerras [this message]
2017-08-30 9:45 ` [PATCH RFC] powerpc: Implements MMIO emulation for lvx/stvx instructions Paul Mackerras
2017-08-30 23:53 ` joserz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901103841.GA29876@fergus.ozlabs.ibm.com \
--to=paulus@ozlabs.org \
--cc=agraf@suse.com \
--cc=joserz@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).