From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-x242.google.com (mail-pf0-x242.google.com [IPv6:2607:f8b0:400e:c00::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3xpPr64HM3zDqZ9 for ; Fri, 8 Sep 2017 14:44:54 +1000 (AEST) Received: by mail-pf0-x242.google.com with SMTP id g65so662687pfe.1 for ; Thu, 07 Sep 2017 21:44:53 -0700 (PDT) Date: Fri, 8 Sep 2017 14:44:37 +1000 From: Nicholas Piggin To: Benjamin Herrenschmidt Cc: linuxppc-dev@lists.ozlabs.org, "Aneesh Kumar K . V" , Anton Blanchard Subject: Re: [RFC PATCH 8/8] powerpc/64s/radix: Only flush local TLB for spurious fault flushes Message-ID: <20170908144437.65c6c982@roar.ozlabs.ibm.com> In-Reply-To: <1504821938.12628.28.camel@kernel.crashing.org> References: <20170907145148.24398-1-npiggin@gmail.com> <20170907145148.24398-9-npiggin@gmail.com> <1504821938.12628.28.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 08 Sep 2017 08:05:38 +1000 Benjamin Herrenschmidt wrote: > On Fri, 2017-09-08 at 00:51 +1000, Nicholas Piggin wrote: > > When permissiveness is relaxed, or found to have been relaxed by > > another thread, we flush that address out of the TLB to avoid a > > future fault or micro-fault due to a stale TLB entry. > > > > Currently for processes with TLBs on other CPUs, this flush is always > > done with a global tlbie. Although that could reduce faults on remote > > CPUs, a broadcast operation seems to be wasteful for something that > > can be handled in-core by the remote CPU if it comes to it. > > > > This is not benchmarked yet. It does seem cut some tlbie operations > > from the bus. > > What happens with the nest MMU here ? Good question, I'm not sure. I can't tell from the UM or not if the agent and NMMU must discard cached translations if there is a translation cached but it has a permission fault. It's not clear from that I've read that if it's relying on the host to send back a tlbie. I'll keep digging. Thanks, Nick