* [PATCH v2] net/ethernet/freescale: fix warning for ucc_geth
@ 2017-09-15 5:58 Valentin Longchamp
2017-09-18 21:56 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Valentin Longchamp @ 2017-09-15 5:58 UTC (permalink / raw)
To: leoli, netdev, christophe.leroy; +Cc: linuxppc-dev, Valentin Longchamp
uf_info.regs is resource_size_t i.e. phys_addr_t that can be either u32
or u64 according to CONFIG_PHYS_ADDR_T_64BIT.
The printk format is thus adaptet to u64 and the regs value cast to u64
to take both u32 and u64 into account.
Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
---
drivers/net/ethernet/freescale/ucc_geth.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c
index f77ba9fa257b..a96b838cffce 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.c
+++ b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -3857,8 +3857,9 @@ static int ucc_geth_probe(struct platform_device* ofdev)
}
if (netif_msg_probe(&debug))
- pr_info("UCC%1d at 0x%8x (irq = %d)\n",
- ug_info->uf_info.ucc_num + 1, ug_info->uf_info.regs,
+ pr_info("UCC%1d at 0x%8llx (irq = %d)\n",
+ ug_info->uf_info.ucc_num + 1,
+ (u64)ug_info->uf_info.regs,
ug_info->uf_info.irq);
/* Create an ethernet device instance */
--
2.13.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] net/ethernet/freescale: fix warning for ucc_geth
2017-09-15 5:58 [PATCH v2] net/ethernet/freescale: fix warning for ucc_geth Valentin Longchamp
@ 2017-09-18 21:56 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-09-18 21:56 UTC (permalink / raw)
To: valentin.longchamp; +Cc: leoli, netdev, christophe.leroy, linuxppc-dev
From: Valentin Longchamp <valentin.longchamp@keymile.com>
Date: Fri, 15 Sep 2017 07:58:47 +0200
> uf_info.regs is resource_size_t i.e. phys_addr_t that can be either u32
> or u64 according to CONFIG_PHYS_ADDR_T_64BIT.
>
> The printk format is thus adaptet to u64 and the regs value cast to u64
> to take both u32 and u64 into account.
>
> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-18 21:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-15 5:58 [PATCH v2] net/ethernet/freescale: fix warning for ucc_geth Valentin Longchamp
2017-09-18 21:56 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).