From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3y363f1sRQzDqNm for ; Fri, 29 Sep 2017 06:38:54 +1000 (AEST) Date: Thu, 28 Sep 2017 13:38:50 -0700 From: Andrew Morton To: Laurent Dufour Cc: Alexei Starovoitov , Paul McKenney , Peter Zijlstra , kirill@shutemov.name, Andi Kleen , Michal Hocko , dave@stgolabs.net, Jan Kara , Matthew Wilcox , Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Will Deacon , Sergey Senozhatsky , "linux-kernel@vger.kernel.org" , linux-mm , haren@linux.vnet.ibm.com, Anshuman Khandual , npiggin@gmail.com, bsingharora@gmail.com, Tim Chen , linuxppc-dev@lists.ozlabs.org, "x86@kernel.org" Subject: Re: [PATCH v3 00/20] Speculative page faults Message-Id: <20170928133850.90c5bf2aac0f1a63e29c01a3@linux-foundation.org> In-Reply-To: <924a79af-6d7a-316a-1eee-3aebbfd4addf@linux.vnet.ibm.com> References: <20170925163443.260d6092160ec704e2b04653@linux-foundation.org> <924a79af-6d7a-316a-1eee-3aebbfd4addf@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 28 Sep 2017 14:29:02 +0200 Laurent Dufour wrote: > > Laurent's [0/n] provides some nice-looking performance benefits for > > workloads which are chosen to show performance benefits(!) but, alas, > > no quantitative testing results for workloads which we may suspect will > > be harmed by the changes(?). Even things as simple as impact upon > > single-threaded pagefault-intensive workloads and its effect upon > > CONFIG_SMP=n .text size? > > I forgot to mention in my previous email the impact on the .text section. > > Here are the metrics I got : > > .text size UP SMP Delta > 4.13-mmotm 8444201 8964137 6.16% > '' +spf 8452041 8971929 6.15% > Delta 0.09% 0.09% > > No major impact as you could see. 8k text increase seems rather a lot actually. That's a lot more userspace cacheclines that get evicted during a fault... Is the feature actually beneficial on uniprocessor?