linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Balbir Singh <bsingharora@gmail.com>
To: mpe@ellerman.id.au
Cc: linuxppc-dev@lists.ozlabs.org, Balbir Singh <bsingharora@gmail.com>
Subject: [PATCH v4 0/5]  Revisit MCE handling for UE Errors
Date: Fri, 29 Sep 2017 14:26:50 +1000	[thread overview]
Message-ID: <20170929042655.14570-1-bsingharora@gmail.com> (raw)

This patch series is designed to hook up memory_failure on
UE errors, this is specially helpful for user_mode UE errors.

The first two patches cleanup bits, remove dead code.
I could not find any users of get_mce_fault_addr().
The second one improves printing of physical address

The third patch walks kernel/user mode page tables in
real mode to extract the effective address of the instruction
that caused the UE error and the effective address it was
trying to access (for load/store). The fourth patch hooks
up the pfn for instruction UE errors (ierror).

The fifth patch hooks up memory_failure to the MCE patch.

TODO:
Log the address in NVRAM, so that we can recover from
bad pages at boot and keep the blacklist persistent.

Changelog v4:
	- Add a #define for MAX_MCE_DEPTH instead of hard
	coding the value
	- Refactor addr_to_pfn to deduce the right parameters
Changelog v3:
	- Check for recursive MCE invocations (suggested
	by Nick)
Changelog v2:
	- Remove pr_warn from real mode to a more delayed
	context, where its OK to warn.
	- Add a trivial patch to align prints of physical
	and effective address
Changelog v1:
	- Address review comments from Nick and Mahesh
	(initialization of pfn and more comments on failure
	when addr_to_pfn() or anaylse_instr() fail)
	- Hookup ierrors to the framework as well
	(comments from Mahesh)

Balbir Singh (5):
  powerpc/mce.c: Remove unused function get_mce_fault_addr()
  powerpc/mce: align the print of physical address better
  powerpc/mce: Hookup derror (load/store) UE errors
  powerpc/mce: Hookup ierror (instruction) UE errors
  powerpc/mce: hookup memory_failure for UE errors

 arch/powerpc/include/asm/exception-64s.h |   5 ++
 arch/powerpc/include/asm/mce.h           |   4 +-
 arch/powerpc/kernel/exceptions-64s.S     |   2 +-
 arch/powerpc/kernel/mce.c                | 117 +++++++++++++++++++------------
 arch/powerpc/kernel/mce_power.c          | 109 +++++++++++++++++++++++++---
 5 files changed, 181 insertions(+), 56 deletions(-)

-- 
2.9.5

             reply	other threads:[~2017-09-29  4:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-29  4:26 Balbir Singh [this message]
2017-09-29  4:26 ` [PATCH v4 1/5] powerpc/mce.c: Remove unused function get_mce_fault_addr() Balbir Singh
2017-10-16  5:13   ` Michael Ellerman
2017-10-16  5:23     ` Balbir Singh
2017-10-19  4:48   ` [v4, " Michael Ellerman
2017-09-29  4:26 ` [PATCH v4 2/5] powerpc/mce: align the print of physical address better Balbir Singh
2017-10-16  5:18   ` Michael Ellerman
2017-10-16  5:36     ` Balbir Singh
2017-09-29  4:26 ` [PATCH v4 3/5] powerpc/mce: Hookup derror (load/store) UE errors Balbir Singh
2017-10-16  5:36   ` Michael Ellerman
2017-10-16  5:38     ` Balbir Singh
2017-09-29  4:26 ` [PATCH v4 4/5] powerpc/mce: Hookup ierror (instruction) " Balbir Singh
2017-09-29  4:26 ` [PATCH v4 5/5] powerpc/mce: hookup memory_failure for " Balbir Singh
2017-10-16  5:38   ` Michael Ellerman
2017-10-16  5:40     ` Balbir Singh
2017-10-16 12:07       ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170929042655.14570-1-bsingharora@gmail.com \
    --to=bsingharora@gmail.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).