From: Cyril Bur <cyrilbur@gmail.com>
To: linux-mtd@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
stewart@linux.vnet.ibm.com
Cc: dwmw2@infradead.org, computersforpeace@gmail.com,
boris.brezillon@free-electrons.com, sjitindarsingh@gmail.com
Subject: [PATCH v4 04/10] mtd: powernv_flash: Don't return -ERESTARTSYS on interrupted token acquisition
Date: Tue, 10 Oct 2017 14:32:56 +1100 [thread overview]
Message-ID: <20171010033302.20854-5-cyrilbur@gmail.com> (raw)
In-Reply-To: <20171010033302.20854-1-cyrilbur@gmail.com>
Because the MTD core might split up a read() or write() from userspace
into several calls to the driver, we may fail to get a token but already
have done some work, best to return -EINTR back to userspace and have
them decide what to do.
Signed-off-by: Cyril Bur <cyrilbur@gmail.com>
---
drivers/mtd/devices/powernv_flash.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/mtd/devices/powernv_flash.c b/drivers/mtd/devices/powernv_flash.c
index 4dd3b5d2feb2..3343d4f5c4f3 100644
--- a/drivers/mtd/devices/powernv_flash.c
+++ b/drivers/mtd/devices/powernv_flash.c
@@ -47,6 +47,11 @@ enum flash_op {
FLASH_OP_ERASE,
};
+/*
+ * Don't return -ERESTARTSYS if we can't get a token, the MTD core
+ * might have split up the call from userspace and called into the
+ * driver more than once, we'll already have done some amount of work.
+ */
static int powernv_flash_async_op(struct mtd_info *mtd, enum flash_op op,
loff_t offset, size_t len, size_t *retlen, u_char *buf)
{
@@ -63,6 +68,8 @@ static int powernv_flash_async_op(struct mtd_info *mtd, enum flash_op op,
if (token < 0) {
if (token != -ERESTARTSYS)
dev_err(dev, "Failed to get an async token\n");
+ else
+ token = -EINTR;
return token;
}
--
2.14.2
next prev parent reply other threads:[~2017-10-10 3:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 3:32 [PATCH v4 00/10] Allow opal-async waiters to get interrupted Cyril Bur
2017-10-10 3:32 ` [PATCH v4 01/10] mtd: powernv_flash: Use WARN_ON_ONCE() rather than BUG_ON() Cyril Bur
2017-10-30 8:49 ` Boris Brezillon
2017-10-10 3:32 ` [PATCH v4 02/10] mtd: powernv_flash: Don't treat OPAL_SUCCESS as an error Cyril Bur
2017-10-30 8:50 ` Boris Brezillon
2017-10-10 3:32 ` [PATCH v4 03/10] mtd: powernv_flash: Remove pointless goto in driver init Cyril Bur
2017-10-30 8:51 ` Boris Brezillon
2017-10-10 3:32 ` Cyril Bur [this message]
2017-10-30 8:51 ` [PATCH v4 04/10] mtd: powernv_flash: Don't return -ERESTARTSYS on interrupted token acquisition Boris Brezillon
2017-10-10 3:32 ` [PATCH v4 05/10] powerpc/opal: Make __opal_async_{get, release}_token() static Cyril Bur
2017-10-10 3:32 ` [PATCH v4 06/10] powerpc/opal: Rework the opal-async interface Cyril Bur
2017-10-10 3:32 ` [PATCH v4 07/10] powernv/opal-sensor: remove not needed lock Cyril Bur
2017-10-10 3:33 ` [PATCH v4 08/10] powerpc/opal: Add opal_async_wait_response_interruptible() to opal-async Cyril Bur
2017-10-10 3:33 ` [PATCH v4 09/10] powerpc/powernv: Add OPAL_BUSY to opal_error_code() Cyril Bur
2017-10-10 3:33 ` [PATCH v4 10/10] mtd: powernv_flash: Use opal_async_wait_response_interruptible() Cyril Bur
2017-10-30 9:14 ` Boris Brezillon
2017-10-30 9:15 ` [PATCH v4 00/10] Allow opal-async waiters to get interrupted Boris Brezillon
2017-10-30 22:52 ` Cyril Bur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010033302.20854-5-cyrilbur@gmail.com \
--to=cyrilbur@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sjitindarsingh@gmail.com \
--cc=stewart@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).