From: Andrew Morton <akpm@linux-foundation.org>
To: Laurent Dufour <ldufour@linux.vnet.ibm.com>
Cc: paulmck@linux.vnet.ibm.com, peterz@infradead.org,
kirill@shutemov.name, ak@linux.intel.com, mhocko@kernel.org,
dave@stgolabs.net, jack@suse.cz,
Matthew Wilcox <willy@infradead.org>,
benh@kernel.crashing.org, mpe@ellerman.id.au, paulus@samba.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
hpa@zytor.com, Will Deacon <will.deacon@arm.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
haren@linux.vnet.ibm.com, khandual@linux.vnet.ibm.com,
npiggin@gmail.com, bsingharora@gmail.com,
Tim Chen <tim.c.chen@linux.intel.com>,
linuxppc-dev@lists.ozlabs.org, x86@kernel.org
Subject: Re: [PATCH v4 19/20] x86/mm: Add speculative pagefault handling
Date: Tue, 10 Oct 2017 14:23:56 -0700 [thread overview]
Message-ID: <20171010142356.b33f8a8fee3427fbdf0708e3@linux-foundation.org> (raw)
In-Reply-To: <1507543672-25821-20-git-send-email-ldufour@linux.vnet.ibm.com>
On Mon, 9 Oct 2017 12:07:51 +0200 Laurent Dufour <ldufour@linux.vnet.ibm.com> wrote:
> +/*
> + * Advertise that we call the Speculative Page Fault handler.
> + */
> +#if defined(CONFIG_X86_64) && defined(CONFIG_SMP)
> +#define __HAVE_ARCH_CALL_SPF
> +#endif
Here's where I mess up your life ;)
It would be more idiomatic to define this in arch/XXX/Kconfig:
config SPF
def_bool y if SMP
then use CONFIG_SPF everywhere.
Also, it would be better if CONFIG_SPF were defined at the start of the
patch series rather than the end, so that as the patches add new code,
that code is actually compilable. For bisection purposes. I can
understand if this is too much work and effort - we can live with
things the way they are now.
This patchset is a ton of new code in very sensitive areas and seems to
have received little review and test. I can do a
merge-and-see-what-happens but it would be quite a risk to send all
this upstream based only on my sketchy review and linux-next runtime
testing. Can we bribe someone?
next prev parent reply other threads:[~2017-10-10 21:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 10:07 [PATCH v4 00/20] Speculative page faults Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 01/20] mm: Dont assume page-table invariance during faults Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 02/20] mm: Prepare for FAULT_FLAG_SPECULATIVE Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 03/20] mm: Introduce pte_spinlock " Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 04/20] mm: VMA sequence count Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 05/20] mm: Protect VMA modifications using " Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 06/20] mm: RCU free VMAs Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 07/20] mm: Cache some VMA fields in the vm_fault structure Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 08/20] mm: Protect SPF handler against anon_vma changes Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 09/20] mm/migrate: Pass vm_fault pointer to migrate_misplaced_page() Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 10/20] mm: Introduce __lru_cache_add_active_or_unevictable Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 11/20] mm: Introduce __maybe_mkwrite() Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 12/20] mm: Introduce __vm_normal_page() Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 13/20] mm: Introduce __page_add_new_anon_rmap() Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 14/20] mm: Provide speculative fault infrastructure Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 15/20] mm: Try spin lock in speculative path Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 16/20] mm: Adding speculative page fault failure trace events Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 17/20] perf: Add a speculative page fault sw event Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 18/20] perf tools: Add support for the SPF perf event Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 19/20] x86/mm: Add speculative pagefault handling Laurent Dufour
2017-10-10 21:23 ` Andrew Morton [this message]
2017-10-11 9:39 ` Laurent Dufour
2017-10-09 10:07 ` [PATCH v4 20/20] powerpc/mm: Add speculative page fault Laurent Dufour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010142356.b33f8a8fee3427fbdf0708e3@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=bsingharora@gmail.com \
--cc=dave@stgolabs.net \
--cc=haren@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=jack@suse.cz \
--cc=khandual@linux.vnet.ibm.com \
--cc=kirill@shutemov.name \
--cc=ldufour@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=will.deacon@arm.com \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).