From: Segher Boessenkool <segher@kernel.crashing.org>
To: Santosh Sivaraj <santosh@fossix.org>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Frederic Weisbecker <fweisbec@gmail.com>,
paul@samba.org
Subject: Re: [PATCH v5] powerpc/vdso64: Add support for CLOCK_{REALTIME/MONOTONIC}_COARSE
Date: Thu, 12 Oct 2017 19:43:37 -0500 [thread overview]
Message-ID: <20171013004336.GV4406@gate.crashing.org> (raw)
In-Reply-To: <20171012043317.xtfhwpf4dmnvu3bj@santosiv.in.ibm.com>
Hi!
On Thu, Oct 12, 2017 at 10:03:17AM +0530, Santosh Sivaraj wrote:
> * Segher Boessenkool <segher@kernel.crashing.org> wrote (on 2017-10-11 17:02:16 +0000):
> > On Wed, Oct 11, 2017 at 02:05:02PM +0530, Santosh Sivaraj wrote:
> > > +70: ld r8,CFG_TB_UPDATE_COUNT(r3)
> > > + andi. r0,r8,1 /* pending update ? loop */
> > > + bne- 70b
> > > + xor r0,r8,r8 /* create dependency */
> >
> > r0 already is 0 here, and already depends on r8. Or is this trying
> > to do something else?
>
> The function from which this piece was borrowed from had a similar
> implementation, didn't figure out why the extra dependency, kept it the way it
> was. See __do_get_tspec function in the same file
> (arch/powerpc/kernel/vdso64/gettimeofday.S).
The xor there is superfluous, too.
Segher
prev parent reply other threads:[~2017-10-13 0:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 8:35 [PATCH v5] powerpc/vdso64: Add support for CLOCK_{REALTIME/MONOTONIC}_COARSE Santosh Sivaraj
2017-10-11 8:49 ` Naveen N. Rao
2017-10-11 17:02 ` Segher Boessenkool
2017-10-12 4:33 ` Santosh Sivaraj
2017-10-13 0:43 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013004336.GV4406@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=fweisbec@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=paul@samba.org \
--cc=santosh@fossix.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).