* [PATCH v1] powerpc/pci: convert to use for_each_pci_bridge() helper
@ 2017-10-13 16:52 Andy Shevchenko
2017-10-31 15:12 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2017-10-13 16:52 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
linuxppc-dev
Cc: Andy Shevchenko
...which makes code slightly cleaner.
Requires: d43f59ce6c50 ("PCI: Add for_each_pci_bridge() helper")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
arch/powerpc/kernel/pci-hotplug.c | 7 ++-----
arch/powerpc/kernel/pci_of_scan.c | 7 ++-----
2 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/arch/powerpc/kernel/pci-hotplug.c b/arch/powerpc/kernel/pci-hotplug.c
index 2d71269e7dc1..741f47295188 100644
--- a/arch/powerpc/kernel/pci-hotplug.c
+++ b/arch/powerpc/kernel/pci-hotplug.c
@@ -134,11 +134,8 @@ void pci_hp_add_devices(struct pci_bus *bus)
pcibios_setup_bus_devices(bus);
max = bus->busn_res.start;
for (pass = 0; pass < 2; pass++) {
- list_for_each_entry(dev, &bus->devices, bus_list) {
- if (pci_is_bridge(dev))
- max = pci_scan_bridge(bus, dev,
- max, pass);
- }
+ for_each_pci_bridge(dev, bus)
+ max = pci_scan_bridge(bus, dev, max, pass);
}
}
pcibios_finish_adding_to_bus(bus);
diff --git a/arch/powerpc/kernel/pci_of_scan.c b/arch/powerpc/kernel/pci_of_scan.c
index 0d790f8432d2..8bdaa2a6fa62 100644
--- a/arch/powerpc/kernel/pci_of_scan.c
+++ b/arch/powerpc/kernel/pci_of_scan.c
@@ -369,11 +369,8 @@ static void __of_scan_bus(struct device_node *node, struct pci_bus *bus,
pcibios_setup_bus_devices(bus);
/* Now scan child busses */
- list_for_each_entry(dev, &bus->devices, bus_list) {
- if (pci_is_bridge(dev)) {
- of_scan_pci_bridge(dev);
- }
- }
+ for_each_pci_bridge(dev, bus)
+ of_scan_pci_bridge(dev);
}
/**
--
2.14.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v1] powerpc/pci: convert to use for_each_pci_bridge() helper
2017-10-13 16:52 [PATCH v1] powerpc/pci: convert to use for_each_pci_bridge() helper Andy Shevchenko
@ 2017-10-31 15:12 ` Andy Shevchenko
2017-10-31 18:33 ` Bjorn Helgaas
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2017-10-31 15:12 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
linuxppc-dev
Cc: Bjorn Helgaas
On Fri, 2017-10-13 at 19:52 +0300, Andy Shevchenko wrote:
> ...which makes code slightly cleaner.
+Cc: Bjorn
Perhaps it makes sense to pass this through PCI if no one objects?
>
> Requires: d43f59ce6c50 ("PCI: Add for_each_pci_bridge() helper")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> arch/powerpc/kernel/pci-hotplug.c | 7 ++-----
> arch/powerpc/kernel/pci_of_scan.c | 7 ++-----
> 2 files changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/arch/powerpc/kernel/pci-hotplug.c
> b/arch/powerpc/kernel/pci-hotplug.c
> index 2d71269e7dc1..741f47295188 100644
> --- a/arch/powerpc/kernel/pci-hotplug.c
> +++ b/arch/powerpc/kernel/pci-hotplug.c
> @@ -134,11 +134,8 @@ void pci_hp_add_devices(struct pci_bus *bus)
> pcibios_setup_bus_devices(bus);
> max = bus->busn_res.start;
> for (pass = 0; pass < 2; pass++) {
> - list_for_each_entry(dev, &bus->devices,
> bus_list) {
> - if (pci_is_bridge(dev))
> - max = pci_scan_bridge(bus,
> dev,
> - max,
> pass);
> - }
> + for_each_pci_bridge(dev, bus)
> + max = pci_scan_bridge(bus, dev, max,
> pass);
> }
> }
> pcibios_finish_adding_to_bus(bus);
> diff --git a/arch/powerpc/kernel/pci_of_scan.c
> b/arch/powerpc/kernel/pci_of_scan.c
> index 0d790f8432d2..8bdaa2a6fa62 100644
> --- a/arch/powerpc/kernel/pci_of_scan.c
> +++ b/arch/powerpc/kernel/pci_of_scan.c
> @@ -369,11 +369,8 @@ static void __of_scan_bus(struct device_node
> *node, struct pci_bus *bus,
> pcibios_setup_bus_devices(bus);
>
> /* Now scan child busses */
> - list_for_each_entry(dev, &bus->devices, bus_list) {
> - if (pci_is_bridge(dev)) {
> - of_scan_pci_bridge(dev);
> - }
> - }
> + for_each_pci_bridge(dev, bus)
> + of_scan_pci_bridge(dev);
> }
>
> /**
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1] powerpc/pci: convert to use for_each_pci_bridge() helper
2017-10-31 15:12 ` Andy Shevchenko
@ 2017-10-31 18:33 ` Bjorn Helgaas
2017-10-31 18:40 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2017-10-31 18:33 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
linuxppc-dev, Bjorn Helgaas
On Tue, Oct 31, 2017 at 10:12 AM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Fri, 2017-10-13 at 19:52 +0300, Andy Shevchenko wrote:
>> ...which makes code slightly cleaner.
>
> +Cc: Bjorn
>
> Perhaps it makes sense to pass this through PCI if no one objects?
Fine with me, but I only apply things that appear on the
linux-pci@vger.kernel.org mailing list.
>> Requires: d43f59ce6c50 ("PCI: Add for_each_pci_bridge() helper")
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>> arch/powerpc/kernel/pci-hotplug.c | 7 ++-----
>> arch/powerpc/kernel/pci_of_scan.c | 7 ++-----
>> 2 files changed, 4 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/powerpc/kernel/pci-hotplug.c
>> b/arch/powerpc/kernel/pci-hotplug.c
>> index 2d71269e7dc1..741f47295188 100644
>> --- a/arch/powerpc/kernel/pci-hotplug.c
>> +++ b/arch/powerpc/kernel/pci-hotplug.c
>> @@ -134,11 +134,8 @@ void pci_hp_add_devices(struct pci_bus *bus)
>> pcibios_setup_bus_devices(bus);
>> max = bus->busn_res.start;
>> for (pass = 0; pass < 2; pass++) {
>> - list_for_each_entry(dev, &bus->devices,
>> bus_list) {
>> - if (pci_is_bridge(dev))
>> - max = pci_scan_bridge(bus,
>> dev,
>> - max,
>> pass);
>> - }
>> + for_each_pci_bridge(dev, bus)
>> + max = pci_scan_bridge(bus, dev, max,
>> pass);
>> }
>> }
>> pcibios_finish_adding_to_bus(bus);
>> diff --git a/arch/powerpc/kernel/pci_of_scan.c
>> b/arch/powerpc/kernel/pci_of_scan.c
>> index 0d790f8432d2..8bdaa2a6fa62 100644
>> --- a/arch/powerpc/kernel/pci_of_scan.c
>> +++ b/arch/powerpc/kernel/pci_of_scan.c
>> @@ -369,11 +369,8 @@ static void __of_scan_bus(struct device_node
>> *node, struct pci_bus *bus,
>> pcibios_setup_bus_devices(bus);
>>
>> /* Now scan child busses */
>> - list_for_each_entry(dev, &bus->devices, bus_list) {
>> - if (pci_is_bridge(dev)) {
>> - of_scan_pci_bridge(dev);
>> - }
>> - }
>> + for_each_pci_bridge(dev, bus)
>> + of_scan_pci_bridge(dev);
>> }
>>
>> /**
>
> --
> Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Intel Finland Oy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1] powerpc/pci: convert to use for_each_pci_bridge() helper
2017-10-31 18:33 ` Bjorn Helgaas
@ 2017-10-31 18:40 ` Andy Shevchenko
2017-11-07 12:54 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2017-10-31 18:40 UTC (permalink / raw)
To: bjorn
Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
linuxppc-dev, Bjorn Helgaas
On Tue, 2017-10-31 at 13:33 -0500, Bjorn Helgaas wrote:
> On Tue, Oct 31, 2017 at 10:12 AM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Fri, 2017-10-13 at 19:52 +0300, Andy Shevchenko wrote:
> > > ...which makes code slightly cleaner.
> >
> > +Cc: Bjorn
> >
> > Perhaps it makes sense to pass this through PCI if no one objects?
>
> Fine with me, but I only apply things that appear on the
> linux-pci@vger.kernel.org mailing list.
I want to wait for powerpc maintainers to Ack and then I'll resend.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] powerpc/pci: convert to use for_each_pci_bridge() helper
2017-10-31 18:40 ` Andy Shevchenko
@ 2017-11-07 12:54 ` Andy Shevchenko
2017-11-08 13:28 ` Michael Ellerman
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2017-11-07 12:54 UTC (permalink / raw)
To: bjorn
Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
linuxppc-dev, Bjorn Helgaas
On Tue, 2017-10-31 at 20:40 +0200, Andy Shevchenko wrote:
> On Tue, 2017-10-31 at 13:33 -0500, Bjorn Helgaas wrote:
> > On Tue, Oct 31, 2017 at 10:12 AM, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Fri, 2017-10-13 at 19:52 +0300, Andy Shevchenko wrote:
> > > > ...which makes code slightly cleaner.
> > >
> > > +Cc: Bjorn
> > >
> > > Perhaps it makes sense to pass this through PCI if no one objects?
> >
> > Fine with me, but I only apply things that appear on the
> > linux-pci@vger.kernel.org mailing list.
>
> I want to wait for powerpc maintainers to Ack and then I'll resend.
Michael, Paul, Benjamin, do you have any concerns on this patch?
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] powerpc/pci: convert to use for_each_pci_bridge() helper
2017-11-07 12:54 ` Andy Shevchenko
@ 2017-11-08 13:28 ` Michael Ellerman
0 siblings, 0 replies; 6+ messages in thread
From: Michael Ellerman @ 2017-11-08 13:28 UTC (permalink / raw)
To: Andy Shevchenko, bjorn
Cc: Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev,
Bjorn Helgaas
Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
> On Tue, 2017-10-31 at 20:40 +0200, Andy Shevchenko wrote:
>> On Tue, 2017-10-31 at 13:33 -0500, Bjorn Helgaas wrote:
>> > On Tue, Oct 31, 2017 at 10:12 AM, Andy Shevchenko
>> > <andriy.shevchenko@linux.intel.com> wrote:
>> > > On Fri, 2017-10-13 at 19:52 +0300, Andy Shevchenko wrote:
>> > > > ...which makes code slightly cleaner.
>> > >
>> > > +Cc: Bjorn
>> > >
>> > > Perhaps it makes sense to pass this through PCI if no one objects?
>> >
>> > Fine with me, but I only apply things that appear on the
>> > linux-pci@vger.kernel.org mailing list.
>>
>> I want to wait for powerpc maintainers to Ack and then I'll resend.
>
> Michael, Paul, Benjamin, do you have any concerns on this patch?
No, assuming it does what it says :)
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-08 13:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-13 16:52 [PATCH v1] powerpc/pci: convert to use for_each_pci_bridge() helper Andy Shevchenko
2017-10-31 15:12 ` Andy Shevchenko
2017-10-31 18:33 ` Bjorn Helgaas
2017-10-31 18:40 ` Andy Shevchenko
2017-11-07 12:54 ` Andy Shevchenko
2017-11-08 13:28 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).