From: Nicholas Piggin <npiggin@gmail.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/mm/radix: Drop unneeded NULL check
Date: Tue, 17 Oct 2017 21:54:24 +1000 [thread overview]
Message-ID: <20171017215339.16354330@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <20171016071100.8497-1-aneesh.kumar@linux.vnet.ibm.com>
On Mon, 16 Oct 2017 12:41:00 +0530
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
> @@ -175,10 +175,9 @@ void radix__local_flush_tlb_page(struct vm_area_struct *vma, unsigned long vmadd
> #ifdef CONFIG_HUGETLB_PAGE
> /* need the return fix for nohash.c */
> if (vma && is_vm_hugetlb_page(vma))
> - return __local_flush_hugetlb_page(vma, vmaddr);
> + return radix__local_flush_hugetlb_page(vma, vmaddr);
> #endif
> - radix__local_flush_tlb_page_psize(vma ? vma->vm_mm : NULL, vmaddr,
> - mmu_virtual_psize);
> + radix__local_flush_tlb_page_psize(vma->vm_mm, vmaddr, mmu_virtual_psize);
> }
> EXPORT_SYMBOL(radix__local_flush_tlb_page);
>
Missed the other NULL pointer check in this hunk.
> @@ -247,10 +246,9 @@ void radix__flush_tlb_page(struct vm_area_struct *vma, unsigned long vmaddr)
> {
> #ifdef CONFIG_HUGETLB_PAGE
> if (vma && is_vm_hugetlb_page(vma))
> - return flush_hugetlb_page(vma, vmaddr);
> + return radix__flush_hugetlb_page(vma, vmaddr);
> #endif
> - radix__flush_tlb_page_psize(vma ? vma->vm_mm : NULL, vmaddr,
> - mmu_virtual_psize);
> + radix__flush_tlb_page_psize(vma->vm_mm, vmaddr, mmu_virtual_psize);
> }
> EXPORT_SYMBOL(radix__flush_tlb_page);
>
And another one.
Thanks,
Nick
next prev parent reply other threads:[~2017-10-17 11:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 7:11 [PATCH] powerpc/mm/radix: Drop unneeded NULL check Aneesh Kumar K.V
2017-10-17 11:54 ` Nicholas Piggin [this message]
2017-10-18 2:45 ` Aneesh Kumar K.V
2017-10-24 8:08 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017215339.16354330@roar.ozlabs.ibm.com \
--to=npiggin@gmail.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).