From: Nicholas Piggin <npiggin@gmail.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 2/3] powerpc: use NMI IPI for smp_send_stop
Date: Tue, 31 Oct 2017 18:43:07 +1100 [thread overview]
Message-ID: <20171031184307.2e0317c4@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <201710240753.BWnpBvpH%fengguang.wu@intel.com>
On Tue, 24 Oct 2017 07:15:30 +0800
kbuild test robot <lkp@intel.com> wrote:
> Hi Nicholas,
>
> [auto build test ERROR on powerpc/next]
> [also build test ERROR on v4.14-rc6 next-20171018]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/avoid-secondary-hold-spinloop-when-possible/20171023-173012
> base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
> config: powerpc-iss476-smp_defconfig (attached as .config)
> compiler: powerpc-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> make.cross ARCH=powerpc
>
> All errors (new ones prefixed by >>):
>
> arch/powerpc/kernel/smp.o: In function `smp_send_stop':
> >> arch/powerpc/kernel/smp.c:563: undefined reference to `smp_send_nmi_ipi'
>
> vim +563 arch/powerpc/kernel/smp.c
>
> 560
> 561 void smp_send_stop(void)
> 562 {
> > 563 smp_send_nmi_ipi(NMI_IPI_ALL_OTHERS, stop_this_cpu, 1000000);
> 564 }
> 565
Good catch, 0day. Thanks.
Rather than have all architectures select NMI_IPI just for this, I
think I'll make it depend on whether NMI_IPI was selected at all.
Otherwise just keep using the normal smp_call_function().
Thanks,
Nick
next prev parent reply other threads:[~2017-10-31 7:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 8:05 [PATCH v2 0/3] avoid secondary hold spinloop when possible Nicholas Piggin
2017-10-23 8:05 ` [PATCH v2 1/3] powerpc/powernv: Always stop secondaries before reboot/shutdown Nicholas Piggin
2017-11-10 11:08 ` Michael Ellerman
2017-11-11 6:00 ` Nicholas Piggin
2017-11-12 11:57 ` Michael Ellerman
2017-10-23 8:05 ` [PATCH v2 2/3] powerpc: use NMI IPI for smp_send_stop Nicholas Piggin
2017-10-23 21:05 ` kbuild test robot
2017-10-23 23:15 ` kbuild test robot
2017-10-31 7:43 ` Nicholas Piggin [this message]
2017-10-23 8:05 ` [PATCH v2 3/3] powerpc/powernv: Avoid waiting for secondary hold spinloop with OPAL Nicholas Piggin
2017-11-14 11:12 ` [v2, " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031184307.2e0317c4@roar.ozlabs.ibm.com \
--to=npiggin@gmail.com \
--cc=kbuild-all@01.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).