linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Philip Li <philip.li@intel.com>
To: Cyril Bur <cyrilbur@gmail.com>
Cc: kbuild test robot <lkp@intel.com>,
	kbuild-all@01.org, linuxppc-dev@lists.ozlabs.org,
	mikey@neuling.org, andrew@aj.id.au, gromero@linux.vnet.ibm.com,
	jk@ozlabs.org, leitao@debian.org, sam@mendozajonas.com
Subject: Re: [PATCH 1/2] powerpc: Don't enable FP/Altivec if not checkpointed
Date: Thu, 2 Nov 2017 11:06:49 +0800	[thread overview]
Message-ID: <20171102030649.GA7418@intel.com> (raw)
In-Reply-To: <1509590647.13316.2.camel@gmail.com>

On Thu, Nov 02, 2017 at 01:44:07PM +1100, Cyril Bur wrote:
> On Thu, 2017-11-02 at 10:19 +0800, kbuild test robot wrote:
> > Hi Cyril,
> > 
> > Thank you for the patch! Yet something to improve:
> > 
> 
> Once again robot, you have done brilliantly! You're 100% correct and
> the last thing I want to do is break the build with
> CONFIG_PPC_TRANSACTIONAL_MEM turned off.
> 
> Life saver,
> Thanks so much kbuild.
Thanks Cyril, we are glad to do some help.

> 
> Cyril
> 
> > [auto build test ERROR on powerpc/next]
> > [also build test ERROR on v4.14-rc7 next-20171018]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> > 
> > url:    https://github.com/0day-ci/linux/commits/Cyril-Bur/powerpc-Don-t-enable-FP-Altivec-if-not-checkpointed/20171102-073816
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
> > config: powerpc-asp8347_defconfig (attached as .config)
> > compiler: powerpc-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
> > reproduce:
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # save the attached .config to linux build tree
> >         make.cross ARCH=powerpc 
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    arch/powerpc/kernel/process.c: In function 'is_transactionally_fp':
> > > > arch/powerpc/kernel/process.c:243:15: error: 'struct thread_struct' has no member named 'ckpt_regs'
> > 
> >       (tsk->thread.ckpt_regs.msr & MSR_FP);
> >                   ^
> >    arch/powerpc/kernel/process.c:244:1: error: control reaches end of non-void function [-Werror=return-type]
> >     }
> >     ^
> >    cc1: all warnings being treated as errors
> > 
> > vim +243 arch/powerpc/kernel/process.c
> > 
> >    239	
> >    240	static int is_transactionally_fp(struct task_struct *tsk)
> >    241	{
> >    242		return msr_tm_active(tsk->thread.regs->msr) &&
> >  > 243			(tsk->thread.ckpt_regs.msr & MSR_FP);
> >    244	}
> >    245	
> > 
> > ---
> > 0-DAY kernel test infrastructure                Open Source Technology Center
> > https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> 

  reply	other threads:[~2017-11-02  3:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-30  5:39 [PATCH 1/2] powerpc: Don't enable FP/Altivec if not checkpointed Cyril Bur
2017-10-30  5:39 ` [PATCH 2/2] powerpc: Always save/restore checkpointed regs during treclaim/trecheckpoint Cyril Bur
2017-11-02  2:19 ` [PATCH 1/2] powerpc: Don't enable FP/Altivec if not checkpointed kbuild test robot
2017-11-02  2:44   ` Cyril Bur
2017-11-02  3:06     ` Philip Li [this message]
2017-11-02  4:58     ` Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171102030649.GA7418@intel.com \
    --to=philip.li@intel.com \
    --cc=andrew@aj.id.au \
    --cc=cyrilbur@gmail.com \
    --cc=gromero@linux.vnet.ibm.com \
    --cc=jk@ozlabs.org \
    --cc=kbuild-all@01.org \
    --cc=leitao@debian.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lkp@intel.com \
    --cc=mikey@neuling.org \
    --cc=sam@mendozajonas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).