From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Balbir Singh <bsingharora@gmail.com>
Cc: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Torsten Duwe <duwe@lst.de>,
Aravinda Prasad <aravinda@linux.vnet.ibm.com>,
Jessica Yu <jeyu@kernel.org>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
"open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)"
<linuxppc-dev@lists.ozlabs.org>,
live-patching@vger.kernel.org
Subject: Re: [PATCH v3] kernel/module_64.c: Add REL24 relocation support of livepatch symbols
Date: Thu, 9 Nov 2017 21:28:23 -0600 [thread overview]
Message-ID: <20171110032823.nnpqsrrfwr6ye4uc@treble> (raw)
In-Reply-To: <CAKTCnznuZFHgVjjnx+gBAk3RSenxS=PJLFBsxOq4Zzw=ru=HMg@mail.gmail.com>
On Fri, Nov 10, 2017 at 01:06:25PM +1100, Balbir Singh wrote:
> On Fri, Nov 10, 2017 at 2:19 AM, Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> > FWIW, I think it won't matter anyway. I'm currently pursuing the option
> > of inserting nops after local calls, because it has less runtime
> > complexity than using a stub.
> >
> > I think I've figured out a way to do it with a GCC plugin, but if that
> > doesn't work I'll try the asm listing sed approach suggested by Michael.
> >
>
> A plugin that runs for the new kernel with the patch? Just for
> specific files involved in the patch?
The plugin will affect the code generation of all functions in the patch
module. So all calls in all replacement functions will have the nops.
Here's a prototype (not yet fully tested):
https://github.com/jpoimboe/kpatch/blob/TODO-ppc-fix/kpatch-build/gcc-plugins/ppc64le-plugin.c
--
Josh
next prev parent reply other threads:[~2017-11-10 3:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 5:18 [PATCH v3] kernel/module_64.c: Add REL24 relocation support of livepatch symbols Kamalesh Babulal
2017-10-31 14:19 ` Naveen N . Rao
2017-10-31 15:30 ` Torsten Duwe
2017-10-31 16:23 ` Naveen N . Rao
2017-10-31 18:39 ` Torsten Duwe
2017-11-01 0:23 ` Balbir Singh
2017-11-07 4:54 ` Josh Poimboeuf
2017-11-07 8:34 ` Michael Ellerman
2017-11-07 11:31 ` Torsten Duwe
2017-11-07 14:52 ` Josh Poimboeuf
2017-11-09 10:55 ` Michael Ellerman
[not found] ` <20171107145233.lmlg5lkfcczkxj4d__32032.512050546$1510066460$gmane$org@treble>
[not found] ` <20171107145233.lmlg5lkfcczkxj4d__32032.512050546$1510066460$gmane$org@treble >
2017-11-09 11:19 ` Naveen N. Rao
2017-11-09 15:19 ` Josh Poimboeuf
2017-11-10 2:06 ` Balbir Singh
2017-11-10 3:28 ` Josh Poimboeuf [this message]
2017-11-10 9:47 ` Michael Ellerman
2017-11-13 8:38 ` Balbir Singh
2017-11-13 11:38 ` Kamalesh Babulal
2017-11-15 10:19 ` Michael Ellerman
2017-11-02 5:49 ` Kamalesh Babulal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110032823.nnpqsrrfwr6ye4uc@treble \
--to=jpoimboe@redhat.com \
--cc=aravinda@linux.vnet.ibm.com \
--cc=bsingharora@gmail.com \
--cc=duwe@lst.de \
--cc=jeyu@kernel.org \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=live-patching@vger.kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox