From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 2/2] powerpc/pci: Unroll two pass loop when scanning bridges
Date: Mon, 13 Nov 2017 16:30:13 +0200 [thread overview]
Message-ID: <20171113143013.GF18997@lahna.fi.intel.com> (raw)
In-Reply-To: <20171110175230.82522-2-andriy.shevchenko@linux.intel.com>
On Fri, Nov 10, 2017 at 07:52:30PM +0200, Andy Shevchenko wrote:
> The current scanning code is really hard to understand because it calls
> the same function in a loop where pass value is changed without any
> comments explaining it:
>
> for (pass = 0; pass < 2; pass++)
> for_each_pci_bridge(dev, bus)
> max = pci_scan_bridge(bus, dev, max, pass);
>
> Unfamiliar reader cannot tell easily what is the purpose of this loop
> without looking at internals of pci_scan_bridge().
>
> In order to make this bit easier to understand, open-code the loop in
> pci_scan_child_bus() and pci_hp_add_bridge() with added comments.
>
> No functional changes intended.
>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2017-11-13 14:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 17:52 [PATCH v2 1/2] powerpc/pci: convert to use for_each_pci_bridge() helper Andy Shevchenko
2017-11-10 17:52 ` [PATCH v2 2/2] powerpc/pci: Unroll two pass loop when scanning bridges Andy Shevchenko
2017-11-13 14:30 ` Mika Westerberg [this message]
2017-11-22 20:12 ` [PATCH v2 1/2] powerpc/pci: convert to use for_each_pci_bridge() helper Bjorn Helgaas
2017-11-23 12:48 ` Michael Ellerman
2017-11-27 18:03 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171113143013.GF18997@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).