From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>,
<brking@pobox.com>, <alexander.h.duyck@intel.com>,
<dipankar@linux.vnet.ibm.com>,
Michael Ellerman <michaele@au1.ibm.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [Intel-wired-lan] [PATCH 0/7] [RESEND] [net] intel: Use smp_rmb rather than read_barrier_depends
Date: Thu, 16 Nov 2017 14:01:12 -0800 [thread overview]
Message-ID: <20171116140112.00007c89@intel.com> (raw)
In-Reply-To: <f360a8cd-518c-1df5-5ffd-91a0e9688ce2@linux.vnet.ibm.com>
On Thu, 16 Nov 2017 14:03:02 -0600
Brian King <brking@linux.vnet.ibm.com> wrote:
> I did think about changing the powerpc definition of read_barrier_depends,
> but after reading up on that barrier, decided it was not the correct barrier
> to be used in this context. Here is some good historical background on
> read_barrier_depends that I found, along with an example.
>
> https://lwn.net/Articles/5159/
>
> Since there is no data-dependency in the code in question here, I think
> the smp_rmb is the proper barrier to use.
Hey Brian, thanks for the explanation, I'll agree with you and Alex
that the smb_rmb replacement is okay. Does your test still pass
without the ->skb NULLs?
next prev parent reply other threads:[~2017-11-16 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1510846675-15169-1-git-send-email-brking@linux.vnet.ibm.com>
[not found] ` <20171116113358.00001d5a@intel.com>
2017-11-16 20:03 ` [Intel-wired-lan] [PATCH 0/7] [RESEND] [net] intel: Use smp_rmb rather than read_barrier_depends Brian King
2017-11-16 21:09 ` Duyck, Alexander H
2017-11-16 22:01 ` Jesse Brandeburg [this message]
2017-11-16 22:57 ` Michael Ellerman
2017-11-17 16:16 ` Brian King
2017-11-17 16:50 ` Duyck, Alexander H
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116140112.00007c89@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=brking@linux.vnet.ibm.com \
--cc=brking@pobox.com \
--cc=dipankar@linux.vnet.ibm.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michaele@au1.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).