From: David Miller <davem@davemloft.net>
To: geert+renesas@glider.be
Cc: michal.simek@xilinx.com, arnd@arndb.de, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit
Date: Wed, 29 Nov 2017 09:44:10 -0500 (EST) [thread overview]
Message-ID: <20171129.094410.1537008794654450709.davem@davemloft.net> (raw)
In-Reply-To: <1511949669-30379-1-git-send-email-geert+renesas@glider.be>
From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: Wed, 29 Nov 2017 11:01:09 +0100
> On 64-bit (e.g. powerpc64/allmodconfig):
>
> drivers/net/ethernet/xilinx/ll_temac_main.c: In function 'temac_start_xmit_done':
> drivers/net/ethernet/xilinx/ll_temac_main.c:633:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> dev_kfree_skb_irq((struct sk_buff *)cur_p->app4);
> ^
>
> cdmac_bd.app4 is u32, so it is too small to hold a kernel pointer.
>
> Note that several other fields in struct cdmac_bd are also too small to
> hold physical addresses on 64-bit platforms.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Yeah, I can't see much value in implementing a hash table converting between
32-bit cookies and 64-bit points just for this if it'll never be actually
used.
Applied, thanks Geert.
prev parent reply other threads:[~2017-11-29 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 10:01 [PATCH] net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit Geert Uytterhoeven
2017-11-29 11:51 ` Michal Simek
2017-11-29 14:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129.094410.1537008794654450709.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=geert+renesas@glider.be \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).