From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-x244.google.com (mail-pg0-x244.google.com [IPv6:2607:f8b0:400e:c05::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3ysFfw5RnmzDrnr for ; Wed, 6 Dec 2017 21:47:04 +1100 (AEDT) Received: by mail-pg0-x244.google.com with SMTP id b18so2014352pgv.10 for ; Wed, 06 Dec 2017 02:47:04 -0800 (PST) Date: Wed, 6 Dec 2017 19:46:56 +0900 From: Sergey Senozhatsky To: Petr Mladek Cc: Sergey Senozhatsky , Sergey Senozhatsky , Tony Luck , Fenghua Yu , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , James Bottomley , Andrew Morton , Jessica Yu , Steven Rostedt , linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 5/6] symbol lookup: introduce dereference_symbol_descriptor() Message-ID: <20171206104656.GC462@jagdpanzerIV> References: <20171109234830.5067-1-sergey.senozhatsky@gmail.com> <20171109234830.5067-6-sergey.senozhatsky@gmail.com> <20171206043649.GB15885@jagdpanzerIV> <20171206103241.t2jbljml7it7wsnz@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20171206103241.t2jbljml7it7wsnz@pathway.suse.cz> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On (12/06/17 11:32), Petr Mladek wrote: [..] > > diff --git a/Documentation/printk-formats.txt b/Documentation/printk-formats.txt > > index aa0a776c817a..02745028e909 100644 > > --- a/Documentation/printk-formats.txt > > +++ b/Documentation/printk-formats.txt > > @@ -61,41 +61,31 @@ Symbols/Function Pointers > > > > :: > > > > - %pF versatile_init+0x0/0x110 > > - %pf versatile_init > > - %pS versatile_init+0x0/0x110 > > - %pSR versatile_init+0x9/0x110 > > + %pS versatile_init+0x0/0x110 > > + %ps versatile_init > > + %pF versatile_init+0x0/0x110 > > + %pf versatile_init > > + %pSR versatile_init+0x9/0x110 > > (with __builtin_extract_return_addr() translation) > > - %ps versatile_init > > - %pB prev_fn_of_versatile_init+0x88/0x88 > > + %pB prev_fn_of_versatile_init+0x88/0x88 > > I was curious why so many lines were changed here. You converted > the 2nd tab to spaces. I put back the tab. The result is: ew... how did that happen. thanks for fixing up. > > +static inline void *dereference_symbol_descriptor(void *ptr) > > +{ > > +#ifdef HAVE_DEREFERENCE_FUNCTION_DESCRIPTOR > > + struct module *mod; > > + > > + ptr = dereference_kernel_function_descriptor(ptr); > > + if (is_ksym_addr((unsigned long)ptr)) > > + return ptr; > > + > > + preempt_disable(); > > + mod = __module_address((unsigned long)ptr); > > + preempt_enable(); > > + > > + if (mod) > > + ptr = dereference_module_function_descriptor(mod, ptr); > > +#endif > > + return ptr; > > +} > > It is a bit too long for an inline function but I did not find a > better solution. It should always be defined and all suitable > .c files are compiled only under certain configuration. Well, > it is a nop on most architectures. or we can move dereference_symbol_descriptor() to vsprintf.c, since all the functions it depends on are now available either as exported symbols or via kallsyms header file. not that it annoys me, so we can keep it as it is. -ss