From: Nicolin Chen <nicoleotsuka@gmail.com>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: broonie@kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, fabio.estevam@nxp.com, timur@tabi.org,
caleb@crome.org, arnaud.mouiche@invoxia.com, lukma@denx.de,
kernel@pengutronix.de
Subject: Re: [PATCH v2 03/11] ASoC: fsl_ssi: Refine all comments
Date: Wed, 13 Dec 2017 14:36:24 -0800 [thread overview]
Message-ID: <20171213223623.GB13576@Asurada-Nvidia> (raw)
In-Reply-To: <e264f260-c8df-a51a-4756-cf2ebf979c66@maciej.szmigiero.name>
On Wed, Dec 13, 2017 at 11:28:51PM +0100, Maciej S. Szmigiero wrote:
> > - /*
> > - * If we're in synchronous mode, and the SSI is already enabled,
> > - * then STCCR is already set properly.
> > - */
> > + /* To support simultaneous TX and RX, bypass it if SSI is enabled */
> > if (enabled && ssi->cpu_dai_drv.symmetric_rates)
> > return 0;
> >
>
> I would say that the old comment described better what is happening -
> since in synchronous (& non-AC'97) mode STCCR controls both TX and RX
> the first direction that is started (either playback or capture) is the
> only direction that needs to configure SSI in hw_params().
There is also an SCR register configuration in this hw_params(),
so the old comment has to be updated. But I would take it into
consideration and revise a bit.
Thanks.
next prev parent reply other threads:[~2017-12-13 22:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 6:34 [PATCH v2 00/11] ASoC: fsl_ssi: Clean up - coding style level Nicolin Chen
2017-12-13 6:34 ` [PATCH v2 01/11] ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi Nicolin Chen
2017-12-13 6:34 ` [PATCH v2 02/11] ASoC: fsl_ssi: Cache pdev->dev pointer Nicolin Chen
2017-12-13 6:34 ` [PATCH v2 03/11] ASoC: fsl_ssi: Refine all comments Nicolin Chen
2017-12-13 22:28 ` Maciej S. Szmigiero
2017-12-13 22:36 ` Nicolin Chen [this message]
2017-12-13 6:34 ` [PATCH v2 04/11] ASoC: fsl_ssi: Rename registers and fields macros Nicolin Chen
2017-12-13 6:34 ` [PATCH v2 05/11] ASoC: fsl_ssi: Refine indentations and wrappings Nicolin Chen
2017-12-13 22:30 ` Maciej S. Szmigiero
2017-12-13 22:33 ` Nicolin Chen
2017-12-13 6:34 ` [PATCH v2 06/11] ASoC: fsl_ssi: Refine printk outputs Nicolin Chen
2017-12-13 6:34 ` [PATCH v2 07/11] ASoC: fsl_ssi: Rename cpu_dai parameter to dai Nicolin Chen
2017-12-19 11:00 ` Applied "ASoC: fsl_ssi: Rename cpu_dai parameter to dai" to the asoc tree Mark Brown
2017-12-13 6:34 ` [PATCH v2 08/11] ASoC: fsl_ssi: Rename scr_val to scr Nicolin Chen
2017-12-13 6:34 ` [PATCH v2 09/11] ASoC: fsl_ssi: Replace fsl_ssi_rxtx_reg_val with fsl_ssi_regvals Nicolin Chen
2017-12-13 6:34 ` [PATCH v2 10/11] ASoC: fsl_ssi: Rename i2smode to i2s_net Nicolin Chen
2017-12-19 10:59 ` Applied "ASoC: fsl_ssi: Rename i2smode to i2s_net" to the asoc tree Mark Brown
2017-12-13 6:34 ` [PATCH v2 11/11] ASoC: fsl_ssi: Define ternary macros to simplify code Nicolin Chen
2017-12-19 10:59 ` Applied "ASoC: fsl_ssi: Define ternary macros to simplify code" to the asoc tree Mark Brown
2017-12-13 22:37 ` [PATCH v2 00/11] ASoC: fsl_ssi: Clean up - coding style level Maciej S. Szmigiero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213223623.GB13576@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.mouiche@invoxia.com \
--cc=broonie@kernel.org \
--cc=caleb@crome.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukma@denx.de \
--cc=mail@maciej.szmigiero.name \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).