linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Nicholas Piggin <npiggin@gmail.com>,
	"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [PATCH 3/9] powerpc/64: rtas avoid accessing paca in 32-bit mode
Date: Fri, 22 Dec 2017 21:17:10 +1000	[thread overview]
Message-ID: <20171222111716.13101-4-npiggin@gmail.com> (raw)
In-Reply-To: <20171222111716.13101-1-npiggin@gmail.com>

Commit 177ba7c647f3 ("powerpc/mm/radix: Limit paca allocation in radix")
limited the paca allocation address to 1G on pSeries because RTAS return
accesses the paca in 32-bit mode:

    On return from RTAS we access the paca variables and we have 64 bit
    disabled. This requires us to limit paca in 32 bit range.

    Fix this by setting ppc64_rma_size to first_memblock_size/1G range.

Avoid this limit by switching to 64-bit mode before accessing any memory.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 arch/powerpc/kernel/entry_64.S | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S
index 36878b6ee8b8..371c05fe250a 100644
--- a/arch/powerpc/kernel/entry_64.S
+++ b/arch/powerpc/kernel/entry_64.S
@@ -1083,6 +1083,17 @@ __enter_rtas:
 rtas_return_loc:
 	FIXUP_ENDIAN
 
+	/*
+	 * Clear RI and set SF before anything.
+	 */
+	mfmsr   r6
+	li	r0,MSR_RI
+	andc	r6,r6,r0
+	sldi	r0,r0,(MSR_SF_LG - MSR_RI_LG)
+	or	r6,r6,r0
+	sync
+	mtmsrd  r6
+
 	/* relocation is off at this point */
 	GET_PACA(r4)
 	clrldi	r4,r4,2			/* convert to realmode address */
@@ -1091,12 +1102,6 @@ rtas_return_loc:
 0:	mflr	r3
 	ld	r3,(1f-0b)(r3)		/* get &rtas_restore_regs */
 
-	mfmsr   r6
-	li	r0,MSR_RI
-	andc	r6,r6,r0
-	sync	
-	mtmsrd  r6
-        
         ld	r1,PACAR1(r4)           /* Restore our SP */
         ld	r4,PACASAVEDMSR(r4)     /* Restore our MSR */
 
-- 
2.15.0

  parent reply	other threads:[~2017-12-22 11:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-22 11:17 [PATCH 0/9] modernize early memory allocation limits and Nicholas Piggin
2017-12-22 11:17 ` [PATCH 1/9] powerpc/powernv: Remove real mode access limit for early allocations Nicholas Piggin
2018-01-22  3:34   ` [1/9] " Michael Ellerman
2017-12-22 11:17 ` [PATCH 2/9] powerpc/pseries: radix is not subject to RMA limit, remove it Nicholas Piggin
2017-12-22 11:17 ` Nicholas Piggin [this message]
2017-12-22 11:17 ` [PATCH 4/9] powerpc/pseries: lift RTAS limit for radix Nicholas Piggin
2017-12-22 11:17 ` [PATCH 5/9] powerpc/pseries: lift RTAS limit for hash Nicholas Piggin
2017-12-22 11:17 ` [PATCH 6/9] powerpc/64s: Relax PACA address limitations Nicholas Piggin
2017-12-22 11:17 ` [PATCH 7/9] powerpc/64s: do not allocate lppaca if we are not virtualized Nicholas Piggin
2017-12-22 11:17 ` [PATCH 8/9] powerpc/64: Use array of paca pointers and allocate pacas individually Nicholas Piggin
2017-12-22 11:17 ` [PATCH 9/9] powerpc/64s: Use array of lppaca pointers and allocate lppacas individually Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171222111716.13101-4-npiggin@gmail.com \
    --to=npiggin@gmail.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).