From: Daniel Thompson <daniel.thompson@linaro.org>
To: Mathieu Malaterre <malat@debian.org>
Cc: no To-header on input <;,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] backlight: Fix old-style function definition
Date: Wed, 3 Jan 2018 10:18:43 +0000 [thread overview]
Message-ID: <20180103101843.vo5vw5vdmzuuy6mv@oak.lan> (raw)
In-Reply-To: <20171226141241.19500-1-malat@debian.org>
On Tue, Dec 26, 2017 at 03:12:41PM +0100, Mathieu Malaterre wrote:
> Fix warning:
>
> drivers/macintosh/via-pmu-backlight.c: In function ‘pmu_backlight_init’:
> drivers/macintosh/via-pmu-backlight.c:140:13: warning: old-style function definition [-Wold-style-definition]
> void __init pmu_backlight_init()
> ^~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> drivers/macintosh/via-pmu-backlight.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c
> index 89ed51571b62..50ada02ae75d 100644
> --- a/drivers/macintosh/via-pmu-backlight.c
> +++ b/drivers/macintosh/via-pmu-backlight.c
> @@ -137,7 +137,7 @@ void pmu_backlight_set_sleep(int sleep)
> }
> #endif /* CONFIG_PM */
>
> -void __init pmu_backlight_init()
> +void __init pmu_backlight_init(void)
> {
> struct backlight_properties props;
> struct backlight_device *bd;
> --
> 2.11.0
>
prev parent reply other threads:[~2018-01-03 10:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-26 14:12 [PATCH 2/2] backlight: Fix old-style function definition Mathieu Malaterre
2018-01-03 10:18 ` Daniel Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103101843.vo5vw5vdmzuuy6mv@oak.lan \
--to=daniel.thompson@linaro.org \
--cc=malat@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox