From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-x230.google.com (mail-pl0-x230.google.com [IPv6:2607:f8b0:400e:c01::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zCHNr6tNLzF0Qc for ; Fri, 5 Jan 2018 06:07:24 +1100 (AEDT) Received: by mail-pl0-x230.google.com with SMTP id 62so1560831pld.7 for ; Thu, 04 Jan 2018 11:07:24 -0800 (PST) Date: Thu, 4 Jan 2018 11:07:33 -0800 From: Nicolin Chen To: "Maciej S. Szmigiero" Cc: timur@tabi.org, broonie@kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, lgirdwood@gmail.com, fabio.estevam@nxp.com, caleb@crome.org, arnaud.mouiche@invoxia.com, lukma@denx.de, kernel@pengutronix.de Subject: Re: [PATCH v1 11/15] ASoC: fsl_ssi: Setup AC97 in dai_probe() Message-ID: <20180104190732.GA27975@Asurada-Nvidia> References: <1513702819-42310-1-git-send-email-nicoleotsuka@gmail.com> <1513702819-42310-12-git-send-email-nicoleotsuka@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Jan 01, 2018 at 04:17:20PM +0100, Maciej S. Szmigiero wrote: > > AC97 configures some registers earlier to start a communication > > with CODECs, so this patch moves those register settings to the > > dai_probe() as well, along with other register configurations. > This patch breaks AC'97 CODEC probing. > > Namely, the fsl_ssi DAI probe callback is only called after the AC'97 > CODEC probe callback, so when you move SSI AC'97 startup to its DAI > probe callback it won't be done yet when the CODEC is probed (and this > requires a working AC'97 interface to successfully complete). Hmm...What's the dependency here? Why is it required like this? I am okay to put everything to a separate fsl_ssi_hw_init() and move it back to the platform probe() though.