From: Paul Mackerras <paulus@ozlabs.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de, npiggin@gmail.com, anton@samba.org,
mikey@neuling.org, oohall@gmail.com
Subject: Re: [PATCH 03/11] powerpc/64s: Simple RFI macro conversions
Date: Tue, 9 Jan 2018 08:01:23 +1100 [thread overview]
Message-ID: <20180108210123.GA9895@fergus.ozlabs.ibm.com> (raw)
In-Reply-To: <20180108170951.GB6176@hirez.programming.kicks-ass.net>
On Mon, Jan 08, 2018 at 06:09:51PM +0100, Peter Zijlstra wrote:
> On Tue, Jan 09, 2018 at 03:54:45AM +1100, Michael Ellerman wrote:
> > diff --git a/arch/powerpc/kvm/book3s_rmhandlers.S b/arch/powerpc/kvm/book3s_rmhandlers.S
> > index 42a4b237df5f..34a5adeff084 100644
> > --- a/arch/powerpc/kvm/book3s_rmhandlers.S
> > +++ b/arch/powerpc/kvm/book3s_rmhandlers.S
> > @@ -46,6 +46,9 @@
> >
> > #define FUNC(name) name
> >
> > +#define RFI_TO_KERNEL RFI
> > +#define RFI_TO_GUEST RFI
> > +
> > .macro INTERRUPT_TRAMPOLINE intno
> >
> > .global kvmppc_trampoline_\intno
>
> Leftovers? The previous patch seems to define all that in common
> headers, why redefine here again?
Not leftovers - this is for the sake of 32-bit compiles. There is
code in this file and in book3s_segment.S which gets used both for
32-bit and 64-bit kernels, and this is supplying a definition on
32-bit platforms. Without this, 32-bit builds that have PR KVM
configured will fail.
Paul.
next prev parent reply other threads:[~2018-01-08 21:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 16:54 [PATCH 01/11] powerpc/pseries: Add H_GET_CPU_CHARACTERISTICS flags & wrapper Michael Ellerman
2018-01-08 16:54 ` [PATCH 02/11] powerpc/64: Add macros for annotating the destination of rfid/hrfid Michael Ellerman
2018-01-08 16:54 ` [PATCH 03/11] powerpc/64s: Simple RFI macro conversions Michael Ellerman
2018-01-08 17:09 ` Peter Zijlstra
2018-01-08 21:01 ` Paul Mackerras [this message]
2018-01-08 22:04 ` Michael Ellerman
2018-01-08 16:54 ` [PATCH 04/11] powerpc/64: Convert the syscall exit path to use RFI_TO_USER/KERNEL Michael Ellerman
2018-01-08 16:54 ` [PATCH 05/11] powerpc/64: Convert fast_exception_return " Michael Ellerman
2018-01-08 16:54 ` [PATCH 06/11] powerpc/64s: Convert slb_miss_common " Michael Ellerman
2018-01-08 16:54 ` [PATCH 07/11] powerpc/64s: Add support for RFI flush of L1-D cache Michael Ellerman
2018-01-09 5:55 ` Jon Masters
2018-01-09 7:02 ` Joel Stanley
2018-01-09 16:05 ` Michael Ellerman
2018-01-25 9:10 ` Christian Zigotzky
2018-01-30 2:11 ` Michael Ellerman
2018-01-08 16:54 ` [PATCH 08/11] powerpc/64s: Support disabling RFI flush with no_rfi_flush and nopti Michael Ellerman
2018-01-08 16:54 ` [PATCH 09/11] powerpc/64s: Allow control of RFI flush via sysfs Michael Ellerman
2018-01-08 17:20 ` Thomas Gleixner
2018-01-08 22:09 ` Michael Ellerman
2018-01-09 6:06 ` Jon Masters
2018-01-09 8:05 ` Greg KH
2018-01-09 8:11 ` Jon Masters
2018-01-09 8:03 ` Greg KH
2018-01-08 16:54 ` [PATCH 10/11] powerpc/pseries: Query hypervisor for RFI flush settings Michael Ellerman
2018-01-08 16:54 ` [PATCH 11/11] powerpc/powernv: Check device-tree " Michael Ellerman
2018-01-08 21:57 ` Tyrel Datwyler
2018-01-11 2:25 ` [01/11] powerpc/pseries: Add H_GET_CPU_CHARACTERISTICS flags & wrapper Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108210123.GA9895@fergus.ozlabs.ibm.com \
--to=paulus@ozlabs.org \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=oohall@gmail.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).