From: Segher Boessenkool <segher@kernel.crashing.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
kbuild test robot <fengguang.wu@intel.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [cryptodev:master 130/134] aes_generic.c:undefined reference to `_restgpr_31_x'
Date: Sun, 14 Jan 2018 18:21:09 -0600 [thread overview]
Message-ID: <20180115002109.GX21977@gate.crashing.org> (raw)
In-Reply-To: <CAK8P3a30k-JjMJ0M9KWXqUMT3eHmuuFvAe1KuKdqNoAiSZrgog@mail.gmail.com>
On Sun, Jan 14, 2018 at 10:40:36PM +0100, Arnd Bergmann wrote:
> Right. I've done some more investigation anyway, starting over with the
> analysis of the gcc options that change it. I've found now that turning
> off '-fcode-hoisting' but leaving on the other options I had suspected
> earlier (-O2 instead of -Os, -ftree-sra, -ftree-pre) also fixes the
> stack problem, and appears to result in the best performance so
> far.
Oh nice!
> I need to rerun the whole test matrix, but that seems rather
> promising, and the result may also help debug what's really happening.
-fcode-hoisting moves all expression evaluation to as early as possible;
for this AES code that means it will increase register pressure a lot,
causing a lot of spilling (well, that is my guess). If that is so, then
we need to dial down -fcode-hoisting a bit, maybe make it aware of
register pressure.
Glad you found a smoking gun,
Segher
prev parent reply other threads:[~2018-01-15 0:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201801122249.RHvvGQJ6%fengguang.wu@intel.com>
2018-01-12 14:55 ` [cryptodev:master 130/134] aes_generic.c:undefined reference to `_restgpr_31_x' Arnd Bergmann
2018-01-12 16:39 ` Segher Boessenkool
2018-01-12 19:43 ` Arnd Bergmann
2018-01-12 20:41 ` Segher Boessenkool
2018-01-12 21:29 ` Arnd Bergmann
2018-01-12 21:41 ` Segher Boessenkool
2018-01-12 21:45 ` Arnd Bergmann
2018-01-12 22:10 ` Segher Boessenkool
2018-01-14 21:40 ` Arnd Bergmann
2018-01-15 0:21 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115002109.GX21977@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=arnd@arndb.de \
--cc=fengguang.wu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).