From: Nicolin Chen <nicoleotsuka@gmail.com>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: timur@tabi.org, broonie@kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, fabio.estevam@nxp.com, caleb@crome.org,
arnaud.mouiche@invoxia.com, lukma@denx.de, kernel@pengutronix.de
Subject: Re: [PATCH v3 16/17] ASoC: fsl_ssi: Move DT related code to a separate probe()
Date: Mon, 15 Jan 2018 13:32:21 -0800 [thread overview]
Message-ID: <20180115213221.GA10868@Asurada> (raw)
In-Reply-To: <0be4b57d-cb28-896a-3d97-f36316a351c5@maciej.szmigiero.name>
On Mon, Jan 15, 2018 at 10:16:39PM +0100, Maciej S. Szmigiero wrote:
> > /* Check if being used in AC97 mode */
> > sprop = of_get_property(np, "fsl,mode", NULL);
> > - if (sprop) {
> > - if (!strcmp(sprop, "ac97-slave"))
> > - ssi->dai_fmt = FSLSSI_AC97_DAIFMT;
> > + if (sprop && !strcmp(sprop, "ac97-slave")) {
> > + ssi->dai_fmt = FSLSSI_AC97_DAIFMT;
> > +
> > + ret = of_property_read_u32(np, "cell-index", &ssi->card_idx);
> > + if (ret) {
> > + dev_err(dev, "failed to get SSI index property\n");
> > + return -EINVAL;
> > + }
> > + strcpy(ssi->card_name, "ac97-codec");
> > }
> >
> > /* Select DMA or FIQ */
> > ssi->use_dma = !of_property_read_bool(np, "fsl,fiq-stream-filter");
> >
> > + /* In synchronous mode, STCK and STFS ports are used by RX as well */
> > + if (!of_find_property(np, "fsl,ssi-asynchronous", NULL))
> > + ssi->synchronous = true;
>
> You are setting ssi->synchronous in the AC'97 mode here, the old code
> didn't do that (see the next patch hunk below).
Will modify this part. Thanks
next prev parent reply other threads:[~2018-01-15 21:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 4:21 [PATCH v3 00/17] ASoC: fsl_ssi: Clean up - program flow level Nicolin Chen
2018-01-15 4:21 ` [PATCH v3 01/17] ASoC: fsl_ssi: Redefine RX and TX macros Nicolin Chen
2018-02-22 13:17 ` Applied "ASoC: fsl_ssi: Redefine RX and TX macros" to the asoc tree Mark Brown
2018-01-15 4:21 ` [PATCH v3 02/17] ASoC: fsl_ssi: Keep ssi->i2s_net updated Nicolin Chen
2018-01-15 4:21 ` [PATCH v3 03/17] ASoC: fsl_ssi: Clean up set_dai_tdm_slot() Nicolin Chen
2018-01-15 4:21 ` [PATCH v3 04/17] ASoC: fsl_ssi: Maintain a mask of active streams Nicolin Chen
2018-02-22 13:17 ` Applied "ASoC: fsl_ssi: Maintain a mask of active streams" to the asoc tree Mark Brown
2018-01-15 4:21 ` [PATCH v3 05/17] ASoC: fsl_ssi: Rename fsl_ssi_disable_val macro Nicolin Chen
2018-02-22 13:16 ` Applied "ASoC: fsl_ssi: Rename fsl_ssi_disable_val macro" to the asoc tree Mark Brown
2018-01-15 4:21 ` [PATCH v3 06/17] ASoC: fsl_ssi: Clear FIFO directly in fsl_ssi_config() Nicolin Chen
2018-01-15 4:21 ` [PATCH v3 07/17] ASoC: fsl_ssi: Clean up helper functions of trigger() Nicolin Chen
2018-02-22 13:16 ` Applied "ASoC: fsl_ssi: Clean up helper functions of trigger()" to the asoc tree Mark Brown
2018-01-15 4:21 ` [PATCH v3 08/17] ASoC: fsl_ssi: Add DAIFMT define for AC97 Nicolin Chen
2018-01-15 4:21 ` [PATCH v3 09/17] ASoC: fsl_ssi: Clean up fsl_ssi_setup_regvals() Nicolin Chen
2018-01-15 4:21 ` [PATCH v3 10/17] ASoC: fsl_ssi: Set xFEN0 and xFEN1 together Nicolin Chen
2018-01-15 4:21 ` [PATCH v3 11/17] ASoC: fsl_ssi: Use snd_soc_init_dma_data instead Nicolin Chen
2018-01-15 4:21 ` [PATCH v3 12/17] ASoC: fsl_ssi: Move one-time configurations to probe() Nicolin Chen
2018-01-15 4:21 ` [PATCH v3 13/17] ASoC: fsl_ssi: Setup AC97 in fsl_ssi_hw_init() Nicolin Chen
2018-01-15 4:21 ` [PATCH v3 14/17] ASoC: fsl_ssi: Clean up _fsl_ssi_set_dai_fmt() Nicolin Chen
2018-01-15 21:16 ` Maciej S. Szmigiero
2018-01-15 21:40 ` Nicolin Chen
2018-01-15 4:21 ` [PATCH v3 15/17] ASoC: fsl_ssi: Add bool synchronous to mark synchronous mode Nicolin Chen
2018-02-22 13:16 ` Applied "ASoC: fsl_ssi: Add bool synchronous to mark synchronous mode" to the asoc tree Mark Brown
2018-01-15 4:21 ` [PATCH v3 16/17] ASoC: fsl_ssi: Move DT related code to a separate probe() Nicolin Chen
2018-01-15 21:16 ` Maciej S. Szmigiero
2018-01-15 21:32 ` Nicolin Chen [this message]
2018-01-15 4:21 ` [PATCH v3 17/17] ASoC: fsl_ssi: Use ssi->streams instead of reading register Nicolin Chen
2018-01-15 18:35 ` [PATCH v3 00/17] ASoC: fsl_ssi: Clean up - program flow level Caleb Crome
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115213221.GA10868@Asurada \
--to=nicoleotsuka@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.mouiche@invoxia.com \
--cc=broonie@kernel.org \
--cc=caleb@crome.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukma@denx.de \
--cc=mail@maciej.szmigiero.name \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).