From: Nicholas Piggin <npiggin@gmail.com>
To: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Cc: mpe@ellerman.id.au, benh@kernel.crashing.org, anton@samba.org,
paulus@samba.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v10 13/17] powerpc/64s: Add support to mask perf interrupts and replay them
Date: Mon, 15 Jan 2018 23:23:41 +1000 [thread overview]
Message-ID: <20180115232341.02e862e4@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <1513742157-28768-14-git-send-email-maddy@linux.vnet.ibm.com>
On Wed, 20 Dec 2017 09:25:53 +0530
Madhavan Srinivasan <maddy@linux.vnet.ibm.com> wrote:
> Two new bit mask field "IRQ_DISABLE_MASK_PMU" is introduced to support
> the masking of PMI and "IRQ_DISABLE_MASK_ALL" to aid interrupt masking
> checking.
>
> Couple of new irq #defs "PACA_IRQ_PMI" and "SOFTEN_VALUE_0xf0*" added
> to use in the exception code to check for PMI interrupts.
>
> In the masked_interrupt handler, for PMIs we reset the MSR[EE] and
> return. In the __check_irq_replay(), replay the PMI interrupt by
> calling performance_monitor_common handler.
I think we need to add all interrupt types which clear MSR[EE] in their
masked handler to the test in may_hard_irq_disable(), otherwise EE can
be enabled before all such pending interrupts are replayed.
We should define all such interrupts in a mask and use that in
may_hard_irq_disable() and corresponding place in masked_##_H##interrupt:
Thanks,
Nick
next prev parent reply other threads:[~2018-01-15 13:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 3:55 [PATCH v10 00/17] powerpc: "paca->soft_enabled" based local atomic operation implementation Madhavan Srinivasan
2017-12-20 3:55 ` [PATCH v10 01/17] powerpc/64: do not trace irqs-off at interrupt return to soft-disabled context Madhavan Srinivasan
2017-12-20 3:55 ` [PATCH v10 02/17] powerpc/64: Add #defines for paca->soft_enabled flags Madhavan Srinivasan
2018-01-22 3:34 ` [v10, " Michael Ellerman
2017-12-20 3:55 ` [PATCH v10 03/17] powerpc/64: Improve inline asm in arch_local_irq_disable Madhavan Srinivasan
2017-12-20 3:55 ` [PATCH v10 04/17] powerpc/64: Fix arch_local_irq_disable() prototype Madhavan Srinivasan
2017-12-20 3:55 ` [PATCH v10 05/17] powerpc/64: move set_soft_enabled(), rename it, add memory clobber Madhavan Srinivasan
2017-12-20 3:55 ` [PATCH v10 06/17] powerpc/64: Implement and use soft_enabled_return API Madhavan Srinivasan
2017-12-20 3:55 ` [PATCH v10 07/17] powerpc/64: Implement and use soft_enabled_set_return API Madhavan Srinivasan
2017-12-20 3:55 ` [PATCH v10 08/17] powerpc/64: Cleanup hard_irq_disable() macro Madhavan Srinivasan
2017-12-20 3:55 ` [PATCH v10 09/17] powerpc/64: Change soft_enabled from flag to bitmask Madhavan Srinivasan
2017-12-20 3:55 ` [PATCH v10 10/17] powerpc/64: Rename soft_enabled to irq_soft_mask Madhavan Srinivasan
2017-12-20 3:55 ` [PATCH v10 11/17] powerpc/64s: Avoid using EXCEPTION_PROLOG_1 macro in MASKABLE_* Madhavan Srinivasan
2017-12-20 3:55 ` [PATCH v10 12/17] powerpc/64s: Add support to take additional parameter in MASKABLE_* macro Madhavan Srinivasan
2017-12-20 3:55 ` [PATCH v10 13/17] powerpc/64s: Add support to mask perf interrupts and replay them Madhavan Srinivasan
2018-01-15 13:23 ` Nicholas Piggin [this message]
2017-12-20 3:55 ` [PATCH v10 14/17] powerpc: Add new kconfig IRQ_DEBUG_SUPPORT Madhavan Srinivasan
2017-12-20 3:55 ` [PATCH v10 15/17] powerpc/64s: Add new set of irq_soft_mask_ functions for PMI masking Madhavan Srinivasan
2017-12-20 3:55 ` [PATCH v10 16/17] powerpc: use generic atomic implementation for local_t Madhavan Srinivasan
2017-12-20 3:55 ` [PATCH v10 17/17] powerpc/64s: Implement local_t using irq soft masking Madhavan Srinivasan
2017-12-20 5:02 ` [PATCH v10 00/17] powerpc: "paca->soft_enabled" based local atomic operation implementation Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115232341.02e862e4@roar.ozlabs.ibm.com \
--to=npiggin@gmail.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).