LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: stable@vger.kernel.org
Cc: greg@kroah.com, linuxppc-dev@ozlabs.org
Subject: [PATCH v4.14 backport 04/10] powerpc/64: Convert the syscall exit path to use RFI_TO_USER/KERNEL
Date: Fri, 19 Jan 2018 00:34:04 +1100	[thread overview]
Message-ID: <20180118133410.18716-4-mpe@ellerman.id.au> (raw)
In-Reply-To: <20180118133410.18716-1-mpe@ellerman.id.au>

From: Nicholas Piggin <npiggin@gmail.com>

commit b8e90cb7bc04a509e821e82ab6ed7a8ef11ba333 upstream.

In the syscall exit path we may be returning to user or kernel
context. We already have a test for that, because we conditionally
restore r13. So use that existing test and branch, and bifurcate the
return based on that.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 arch/powerpc/kernel/entry_64.S | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S
index 5ae0a435417d..150c402728d1 100644
--- a/arch/powerpc/kernel/entry_64.S
+++ b/arch/powerpc/kernel/entry_64.S
@@ -267,13 +267,23 @@ BEGIN_FTR_SECTION
 END_FTR_SECTION_IFSET(CPU_FTR_HAS_PPR)
 
 	ld	r13,GPR13(r1)	/* only restore r13 if returning to usermode */
+	ld	r2,GPR2(r1)
+	ld	r1,GPR1(r1)
+	mtlr	r4
+	mtcr	r5
+	mtspr	SPRN_SRR0,r7
+	mtspr	SPRN_SRR1,r8
+	RFI_TO_USER
+	b	.	/* prevent speculative execution */
+
+	/* exit to kernel */
 1:	ld	r2,GPR2(r1)
 	ld	r1,GPR1(r1)
 	mtlr	r4
 	mtcr	r5
 	mtspr	SPRN_SRR0,r7
 	mtspr	SPRN_SRR1,r8
-	RFI
+	RFI_TO_KERNEL
 	b	.	/* prevent speculative execution */
 
 .Lsyscall_error:
-- 
2.14.3

  parent reply	other threads:[~2018-01-18 13:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-18 13:34 [PATCH v4.14 backport 01/10] powerpc/pseries: Add H_GET_CPU_CHARACTERISTICS flags & wrapper Michael Ellerman
2018-01-18 13:34 ` [PATCH v4.14 backport 02/10] powerpc/64: Add macros for annotating the destination of rfid/hrfid Michael Ellerman
2018-01-18 13:34 ` [PATCH v4.14 backport 03/10] powerpc/64s: Simple RFI macro conversions Michael Ellerman
2018-01-18 13:34 ` Michael Ellerman [this message]
2018-01-18 13:34 ` [PATCH v4.14 backport 05/10] powerpc/64: Convert fast_exception_return to use RFI_TO_USER/KERNEL Michael Ellerman
2018-01-18 13:34 ` [PATCH v4.14 backport 06/10] powerpc/64s: Convert slb_miss_common " Michael Ellerman
2018-01-18 13:34 ` [PATCH v4.14 backport 07/10] powerpc/64s: Add support for RFI flush of L1-D cache Michael Ellerman
2018-01-18 13:34 ` [PATCH v4.14 backport 08/10] powerpc/64s: Support disabling RFI flush with no_rfi_flush and nopti Michael Ellerman
2018-01-18 13:34 ` [PATCH v4.14 backport 09/10] powerpc/pseries: Query hypervisor for RFI flush settings Michael Ellerman
2018-01-18 13:34 ` [PATCH v4.14 backport 10/10] powerpc/powernv: Check device-tree " Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180118133410.18716-4-mpe@ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=greg@kroah.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox