linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: alexander.shishkin@linux.intel.com, jolsa@redhat.com,
	namhyung@kernel.org, linux-kernel@vger.kernel.org,
	brueckner@linux.vnet.ibm.com, tmricht@linux.vnet.ibm.com,
	linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au
Subject: Re: [PATCH 3/3] perf trace powerpc: Use generated syscall table
Date: Mon, 29 Jan 2018 11:33:20 +0100	[thread overview]
Message-ID: <20180129103320.GA9986@kernel.org> (raw)
In-Reply-To: <20180129083417.31240-4-ravi.bangoria@linux.vnet.ibm.com>

Em Mon, Jan 29, 2018 at 02:04:17PM +0530, Ravi Bangoria escreveu:
> +++ b/tools/perf/util/syscalltbl.c
> @@ -30,6 +30,10 @@
>  #include <asm/syscalls_64.c>
>  const int syscalltbl_native_max_id = SYSCALLTBL_S390_64_MAX_ID;
>  static const char **syscalltbl_native = syscalltbl_s390_64;
> +#elif defined(__powerpc64__)
> +#include <asm/syscalls_64.c>
> +const int syscalltbl_native_max_id = SYSCALLTBL_POWERPC_64_MAX_ID;
> +static const char **syscalltbl_native = syscalltbl_powerpc_64;
>  #endif

This is so cool! Thanks!

At some point we'll remove these #elif, have all of then linked, so that
we can do cross-platform interpreting of perf.data files generated with
'perf trace record', i.e. 'perf trace -i perf.data.recorded.on.s390' on
a powerpc64 or x86 machine.

We're paving the way to that with patches like yours and those for
s/390, thanks again!

- Arnaldo

  reply	other threads:[~2018-01-29 10:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-29  8:34 [PATCH 0/3] perf trace powerpc: Remove libaudit dependency for syscalls Ravi Bangoria
2018-01-29  8:34 ` [PATCH 1/3] tools include powerpc: Grab a copy of arch/powerpc/include/uapi/asm/unistd.h Ravi Bangoria
2018-02-16 16:52   ` Arnaldo Carvalho de Melo
2018-02-16 16:56     ` Arnaldo Carvalho de Melo
2018-02-16 17:03       ` Arnaldo Carvalho de Melo
2018-02-16 17:08         ` Arnaldo Carvalho de Melo
2018-02-16 17:29           ` Arnaldo Carvalho de Melo
2018-02-16 17:50             ` Arnaldo Carvalho de Melo
2018-02-17  6:17               ` Ravi Bangoria
2018-02-19  4:49               ` Michael Ellerman
2018-01-29  8:34 ` [PATCH 2/3] perf powerpc: Generate system call table from asm/unistd.h Ravi Bangoria
2018-01-29  8:34 ` [PATCH 3/3] perf trace powerpc: Use generated syscall table Ravi Bangoria
2018-01-29 10:33   ` Arnaldo Carvalho de Melo [this message]
2018-02-15 13:43 ` [PATCH 0/3] perf trace powerpc: Remove libaudit dependency for syscalls Arnaldo Carvalho de Melo
2018-02-15 13:56   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180129103320.GA9986@kernel.org \
    --to=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=brueckner@linux.vnet.ibm.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=namhyung@kernel.org \
    --cc=ravi.bangoria@linux.vnet.ibm.com \
    --cc=tmricht@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).