From: Nicholas Piggin <npiggin@gmail.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Scott Wood <oss@buserror.net>,
aneesh.kumar@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 2/5] powerpc/mm/slice: Enhance for supporting PPC32
Date: Sun, 11 Feb 2018 23:59:44 +1000 [thread overview]
Message-ID: <20180211235944.14c2be39@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <0ac518636ae1e601ea0732dd69b48dcd0f347285.1518226173.git.christophe.leroy@c-s.fr>
On Sat, 10 Feb 2018 13:54:27 +0100 (CET)
Christophe Leroy <christophe.leroy@c-s.fr> wrote:
> In preparation for the following patch which will fix an issue on
> the 8xx by re-using the 'slices', this patch enhances the
> 'slices' implementation to support 32 bits CPUs.
>
> On PPC32, the address space is limited to 4Gbytes, hence only the low
> slices will be used.
>
> This patch moves "slices" functions prototypes from page64.h to slice.h
>
> The high slices use bitmaps. As bitmap functions are not prepared to
> handling bitmaps of size 0, the bitmap_xxx() calls are wrapped into
> slice_bitmap_xxx() functions which will void on PPC32
On this last point, I think it would be better to put these with the
existing slice bitmap functions in slice.c and just have a few #ifdefs
for SLICE_NUM_HIGH == 0.
Thanks,
Nick
next prev parent reply other threads:[~2018-02-11 14:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-10 12:54 [PATCH v4 1/5] powerpc/mm/slice: Remove intermediate bitmap copy Christophe Leroy
2018-02-10 12:54 ` [PATCH v4 2/5] powerpc/mm/slice: Enhance for supporting PPC32 Christophe Leroy
2018-02-11 13:59 ` Nicholas Piggin [this message]
2018-02-11 15:34 ` Aneesh Kumar K.V
2018-02-11 23:34 ` Nicholas Piggin
2018-02-22 14:24 ` Christophe LEROY
2018-02-12 5:46 ` Aneesh Kumar K.V
2018-02-10 12:54 ` [PATCH v4 3/5] powerpc/mm/slice: Fix hugepage allocation at hint address on 8xx Christophe Leroy
2018-02-10 12:54 ` [PATCH v4 4/5] powerpc/mm/slice: Allow up to 64 low slices Christophe Leroy
2018-02-12 5:47 ` Aneesh Kumar K.V
2018-02-10 12:54 ` [PATCH v4 5/5] powerpc/8xx: Increase number of slices to 64 Christophe Leroy
2018-02-10 14:43 ` [PATCH v4 1/5] powerpc/mm/slice: Remove intermediate bitmap copy Nicholas Piggin
2018-02-10 14:57 ` Christophe LEROY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180211235944.14c2be39@roar.ozlabs.ibm.com \
--to=npiggin@gmail.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).