From: Ingo Molnar <mingo@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Fengguang Wu <fengguang.wu@intel.com>,
iommu@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
linux-s390 <linux-s390@vger.kernel.org>,
sparclinux@vger.kernel.org, X86 ML <x86@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
John Johansen <john.johansen@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] headers: untangle kmemleak.h from mm.h
Date: Mon, 12 Feb 2018 08:27:27 +0100 [thread overview]
Message-ID: <20180212072727.saupl35jvwex6hbe@gmail.com> (raw)
In-Reply-To: <a4629db7-194d-3c7c-c8fd-24f61b220a70@infradead.org>
* Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Currently <linux/slab.h> #includes <linux/kmemleak.h> for no obvious
> reason. It looks like it's only a convenience, so remove kmemleak.h
> from slab.h and add <linux/kmemleak.h> to any users of kmemleak_*
> that don't already #include it.
> Also remove <linux/kmemleak.h> from source files that do not use it.
>
> This is tested on i386 allmodconfig and x86_64 allmodconfig. It
> would be good to run it through the 0day bot for other $ARCHes.
> I have neither the horsepower nor the storage space for the other
> $ARCHes.
>
> [slab.h is the second most used header file after module.h; kernel.h
> is right there with slab.h. There could be some minor error in the
> counting due to some #includes having comments after them and I
> didn't combine all of those.]
>
> This is Lingchi patch #1 (death by a thousand cuts, applied to kernel
> header files).
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Nice find:
Reviewed-by: Ingo Molnar <mingo@kernel.org>
I agree that it needs to go through 0-day to find any hidden dependencies we might
have grown due to this.
Thanks,
Ingo
next prev parent reply other threads:[~2018-02-12 7:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 7:20 [PATCH] headers: untangle kmemleak.h from mm.h Randy Dunlap
2018-02-12 7:27 ` Ingo Molnar [this message]
2018-02-14 0:48 ` Randy Dunlap
2018-02-12 12:28 ` Michael Ellerman
2018-02-12 19:40 ` Randy Dunlap
2018-02-13 10:09 ` Michael Ellerman
2018-02-13 17:51 ` Randy Dunlap
2018-02-12 21:16 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212072727.saupl35jvwex6hbe@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=john.johansen@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sparclinux@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).