From: Viresh Kumar <viresh.kumar@linaro.org>
To: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
Cc: rjw@rjwysocki.net, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
mpe@ellerman.id.au
Subject: Re: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()
Date: Mon, 12 Feb 2018 16:10:30 +0530 [thread overview]
Message-ID: <20180212104030.GV28462@vireshk-i7> (raw)
In-Reply-To: <14e2fe70-7628-4377-664d-3c4b0071e08d@linux.vnet.ibm.com>
On 12-02-18, 16:03, Shilpasri G Bhat wrote:
> I agree too. There is no way we can get -1 with initialized cpu frequency table.
> We don't initialize powernv-cpufreq if we don't have valid CPU frequency
> entries. Is there any other way to suppress the Coverity tool warning apart from
> ignoring it?
So IIUC, this warning is generated by an external tool after static
analysis of the code ?
If yes, then just ignore the warning. We shouldn't try fixing the
kernel because a tool isn't smart enough to catch intentional
ignorance of the return value here.
--
viresh
next prev parent reply other threads:[~2018-02-12 10:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 10:21 [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl() Shilpasri G Bhat
2018-02-12 10:29 ` Viresh Kumar
2018-02-12 10:33 ` Shilpasri G Bhat
2018-02-12 10:40 ` Viresh Kumar [this message]
2018-02-26 9:48 ` Rafael J. Wysocki
2018-02-21 5:39 ` Michael Ellerman
2018-02-21 5:54 ` Viresh Kumar
2018-02-21 9:27 ` Rafael J. Wysocki
2018-02-21 10:02 ` Viresh Kumar
2018-02-21 10:17 ` Rafael J. Wysocki
2018-02-21 10:19 ` Viresh Kumar
2018-02-21 13:13 ` Michael Ellerman
2018-02-21 13:25 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212104030.GV28462@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=rjw@rjwysocki.net \
--cc=shilpa.bhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).