From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, linux-kernel@vger.kernel.org,
brueckner@linux.vnet.ibm.com, tmricht@linux.vnet.ibm.com,
linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au
Subject: Re: [PATCH 1/3] tools include powerpc: Grab a copy of arch/powerpc/include/uapi/asm/unistd.h
Date: Fri, 16 Feb 2018 14:29:01 -0300 [thread overview]
Message-ID: <20180216172901.GB16919@kernel.org> (raw)
In-Reply-To: <20180216170812.GA16919@kernel.org>
Em Fri, Feb 16, 2018 at 02:08:12PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Feb 16, 2018 at 02:03:36PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Feb 16, 2018 at 01:56:16PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Fri, Feb 16, 2018 at 01:52:45PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > > Em Mon, Jan 29, 2018 at 02:04:15PM +0530, Ravi Bangoria escreveu:
> > > > > Will be used for generating the syscall id/string translation table.
> > > > >
> > > > > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
> > > > > ---
> > > > > tools/arch/powerpc/include/uapi/asm/unistd.h | 399 +++++++++++++++++++++++++++
> > > > > tools/perf/check-headers.sh | 1 +
> > > > > 2 files changed, 400 insertions(+)
> > > > > create mode 100644 tools/arch/powerpc/include/uapi/asm/unistd.h
> > > >
> > > > Not building on a cross-compiling environment (ubuntu 16.04), I'm checking...
> > >
> > > BTW, details about that environment:
> > >
> > > 46 29.83 ubuntu:16.04-x-powerpc : FAIL powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
> >
> > So, you did it just for ppc64? Because...
> >
> > 46 29.83 ubuntu:16.04-x-powerpc : FAIL powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
> > 47 69.81 ubuntu:16.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.1) 5.4.0 20160609
> > 48 68.35 ubuntu:16.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
> >
> > Its just on ppc32 that his is falling apart.
>
> So, $(SRCARCH) maps to both powerpc and powerpc64m which will set
> NO_SYSCALL_TABLE to zero, thus linking against
> tools/perf/util/syscalltbl.o, which will include the generated
> syscalls_64.c only for ppc64, b00m.
Ok, so after looking at:
commit eef289f79c03ba5ca197e2ac1e33906175f01c39
Author: Paul Mackerras <paulus@samba.org>
Date: Mon Oct 10 22:56:11 2005 +1000
powerpc: Merge asm/unistd.h
Signed-off-by: Paul Mackerras <paulus@samba.org>
----
Humm, we need to create two tables, one for 32-bit and another for 64,
even with ppc not having (AFAIK) clashes in syscall numbers for 32/64...
Trying to do it now.
- Arnaldo
next prev parent reply other threads:[~2018-02-16 17:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 8:34 [PATCH 0/3] perf trace powerpc: Remove libaudit dependency for syscalls Ravi Bangoria
2018-01-29 8:34 ` [PATCH 1/3] tools include powerpc: Grab a copy of arch/powerpc/include/uapi/asm/unistd.h Ravi Bangoria
2018-02-16 16:52 ` Arnaldo Carvalho de Melo
2018-02-16 16:56 ` Arnaldo Carvalho de Melo
2018-02-16 17:03 ` Arnaldo Carvalho de Melo
2018-02-16 17:08 ` Arnaldo Carvalho de Melo
2018-02-16 17:29 ` Arnaldo Carvalho de Melo [this message]
2018-02-16 17:50 ` Arnaldo Carvalho de Melo
2018-02-17 6:17 ` Ravi Bangoria
2018-02-19 4:49 ` Michael Ellerman
2018-01-29 8:34 ` [PATCH 2/3] perf powerpc: Generate system call table from asm/unistd.h Ravi Bangoria
2018-01-29 8:34 ` [PATCH 3/3] perf trace powerpc: Use generated syscall table Ravi Bangoria
2018-01-29 10:33 ` Arnaldo Carvalho de Melo
2018-02-15 13:43 ` [PATCH 0/3] perf trace powerpc: Remove libaudit dependency for syscalls Arnaldo Carvalho de Melo
2018-02-15 13:56 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180216172901.GB16919@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=brueckner@linux.vnet.ibm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=namhyung@kernel.org \
--cc=ravi.bangoria@linux.vnet.ibm.com \
--cc=tmricht@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).