From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>, Joel Stanley <joel@jms.id.au>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Eric Anholt <eric@anholt.net>,
Stefan Wahren <stefan.wahren@i2se.com>,
Linus Walleij <linus.walleij@linaro.org>,
Support Opensource <support.opensource@diasemi.com>,
Baruch Siach <baruch@tkos.co.il>,
Jimmy Vance <jimmy.vance@hpe.com>,
Keguang Zhang <keguang.zhang@gmail.com>,
Joachim Eastwood <manabian@gmail.com>,
Tomas Winkler <tomas.winkler@intel.com>,
Johannes Thumshirn <morbidrsa@gmail.com>,
Andreas Werner <andreas.werner@men.de>,
Carlo Caione <carlo@caione.org>,
Kevin Hilman <khilman@baylibre.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Wan ZongShun <mcuos.com@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Sylvain Lemieux <slemieux.tyco@gmail.com>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Zwane Mwaikambo <zwanem@gmail.com>,
Jim Cromie <jim.cromie@gmail.com>, Barry Song <baohua@kernel.org>,
Patrice Chotard <patrice.chotard@st.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
Marc Gonzalez <marc.w.gonzalez@free.fr>,
Mans Rullgard <mans@mansr.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Jun Nie <jun.nie@linaro.org>, Baoyou Xie <baoyou.xie@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
adi-buildroot-devel@lists.sourceforge.net,
linux-mips@linux-mips.org, linux-amlogic@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, patches@opensource.cirrus.com
Subject: Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem
Date: Tue, 20 Feb 2018 07:49:55 -0500 [thread overview]
Message-ID: <20180220124955.GA17814@sophia> (raw)
In-Reply-To: <20180220104542.32286-1-marcus.folkesson@gmail.com>
On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote:
>- Add SPDX identifier
>- Remove boiler plate license text
>- If MODULE_LICENSE and boiler plate does not match, go for boiler plate
> license
>
>Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
>Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
>Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
>Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
>Acked-by: Michal Simek <michal.simek@xilinx.com>
>---
>
>Notes:
> v2:
> - Put back removed copyright texts for meson_gxbb_wdt and coh901327_wdt
> - Change to BSD-3-Clause for meson_gxbb_wdt
> v1: Please have an extra look at meson_gxbb_wdt.c
[...]
>diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/ebc-c384_wdt.c
>index 2170b275ea01..c173b6f5c866 100644
>--- a/drivers/watchdog/ebc-c384_wdt.c
>+++ b/drivers/watchdog/ebc-c384_wdt.c
>@@ -1,15 +1,8 @@
>+// SPDX-License-Identifier: GPL-2.0
> /*
> * Watchdog timer driver for the WinSystems EBC-C384
> * Copyright (C) 2016 William Breathitt Gray
> *
>- * This program is free software; you can redistribute it and/or modify
>- * it under the terms of the GNU General Public License, version 2, as
>- * published by the Free Software Foundation.
>- *
>- * This program is distributed in the hope that it will be useful, but
>- * WITHOUT ANY WARRANTY; without even the implied warranty of
>- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>- * General Public License for more details.
> */
> #include <linux/device.h>
> #include <linux/dmi.h>
I have no problem with adding a SPDX line to the top of this file, but
use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentional
with the selection of GPL version 2 only when I published this code.
Furthermore, please do not remove the existing copyright text; although
it's just boilerplate for some, I was careful with the selection of
these words, and I worry the SPDX line only -- despite its useful
conciseness -- may lead to misunderstandings about my intentioned
license for this code.
For the time being, I can't Ack this patch with the changes it makes
currently:
Nacked-by: William Breathitt Gray <vilhelm.gray@gmail.com>
William Breathitt Gray
next prev parent reply other threads:[~2018-02-20 12:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 10:45 [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem Marcus Folkesson
2018-02-20 10:58 ` Måns Rullgård
2018-02-20 11:24 ` Thierry Reding
2018-02-20 11:25 ` Neil Armstrong
2018-02-20 12:49 ` William Breathitt Gray [this message]
2018-02-20 13:21 ` Marcus Folkesson
2018-02-20 15:13 ` Guenter Roeck
2018-02-20 15:33 ` Marcus Folkesson
2018-02-20 18:14 ` William Breathitt Gray
2018-02-20 18:45 ` Marcus Folkesson
2018-02-20 16:26 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220124955.GA17814@sophia \
--to=vilhelm.gray@gmail.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=alexandre.belloni@free-electrons.com \
--cc=andreas.werner@men.de \
--cc=baohua@kernel.org \
--cc=baoyou.xie@linaro.org \
--cc=baruch@tkos.co.il \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=benh@kernel.crashing.org \
--cc=carlo@caione.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=jim.cromie@gmail.com \
--cc=jimmy.vance@hpe.com \
--cc=joel@jms.id.au \
--cc=jonathanh@nvidia.com \
--cc=jun.nie@linaro.org \
--cc=keguang.zhang@gmail.com \
--cc=kgene@kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=manabian@gmail.com \
--cc=mans@mansr.com \
--cc=marc.w.gonzalez@free.fr \
--cc=marcus.folkesson@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=maxime.ripard@bootlin.com \
--cc=mcuos.com@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=morbidrsa@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=nicolas.ferre@microchip.com \
--cc=patches@opensource.cirrus.com \
--cc=patrice.chotard@st.com \
--cc=paulus@samba.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=slemieux.tyco@gmail.com \
--cc=stefan.wahren@i2se.com \
--cc=support.opensource@diasemi.com \
--cc=thierry.reding@gmail.com \
--cc=tomas.winkler@intel.com \
--cc=vz@mleia.com \
--cc=wens@csie.org \
--cc=wim@linux-watchdog.org \
--cc=yamada.masahiro@socionext.com \
--cc=zwanem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).