From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x243.google.com (mail-lf0-x243.google.com [IPv6:2a00:1450:4010:c07::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zmFnD2HqczDqvJ for ; Wed, 21 Feb 2018 09:35:27 +1100 (AEDT) Received: by mail-lf0-x243.google.com with SMTP id v9so6466137lfa.11 for ; Tue, 20 Feb 2018 14:35:27 -0800 (PST) Date: Tue, 20 Feb 2018 16:33:26 +0100 From: Marcus Folkesson To: Guenter Roeck Cc: William Breathitt Gray , Wim Van Sebroeck , Joel Stanley , Nicolas Ferre , Alexandre Belloni , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Eric Anholt , Stefan Wahren , Linus Walleij , Support Opensource , Baruch Siach , Jimmy Vance , Keguang Zhang , Joachim Eastwood , Tomas Winkler , Johannes Thumshirn , Andreas Werner , Carlo Caione , Kevin Hilman , Matthias Brugger , Wan ZongShun , Michal Simek , Vladimir Zapolskiy , Sylvain Lemieux , Kukjin Kim , Krzysztof Kozlowski , Zwane Mwaikambo , Jim Cromie , Barry Song , Patrice Chotard , Maxime Ripard , Chen-Yu Tsai , Marc Gonzalez , Mans Rullgard , Thierry Reding , Jonathan Hunter , Masahiro Yamada , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Jun Nie , Baoyou Xie , Shawn Guo , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, adi-buildroot-devel@lists.sourceforge.net, linux-mips@linux-mips.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, patches@opensource.cirrus.com Subject: Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem Message-ID: <20180220153326.GE24311@gmail.com> References: <20180220104542.32286-1-marcus.folkesson@gmail.com> <20180220124955.GA17814@sophia> <20180220132103.GD24311@gmail.com> <48db897e-8a61-a5bc-5a61-56349cafaa10@roeck-us.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MiFvc8Vo6wRSORdP" In-Reply-To: <48db897e-8a61-a5bc-5a61-56349cafaa10@roeck-us.net> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --MiFvc8Vo6wRSORdP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 20, 2018 at 07:13:43AM -0800, Guenter Roeck wrote: > On 02/20/2018 05:21 AM, Marcus Folkesson wrote: > > Hello William, > >=20 > > On Tue, Feb 20, 2018 at 07:49:55AM -0500, William Breathitt Gray wrote: > > > On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote: > > > > - Add SPDX identifier > > > > - Remove boiler plate license text > > > > - If MODULE_LICENSE and boiler plate does not match, go for boiler = plate > > > > license > > > >=20 > > > > Signed-off-by: Marcus Folkesson > > > > Acked-by: Adam Thomson > > > > Acked-by: Charles Keepax > > > > Acked-by: Nicolas Ferre > > > > Acked-by: Michal Simek > > > > --- > > > >=20 > > > > Notes: > > > > v2: > > > > - Put back removed copyright texts for meson_gxbb_wdt and coh9= 01327_wdt > > > > - Change to BSD-3-Clause for meson_gxbb_wdt > > > > v1: Please have an extra look at meson_gxbb_wdt.c > > >=20 > > > [...] > > >=20 > > > > diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/ebc= -c384_wdt.c > > > > index 2170b275ea01..c173b6f5c866 100644 > > > > --- a/drivers/watchdog/ebc-c384_wdt.c > > > > +++ b/drivers/watchdog/ebc-c384_wdt.c > > > > @@ -1,15 +1,8 @@ > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > /* > > > > * Watchdog timer driver for the WinSystems EBC-C384 > > > > * Copyright (C) 2016 William Breathitt Gray > > > > * The copyright is untouched? > > > > - * This program is free software; you can redistribute it and/or m= odify > > > > - * it under the terms of the GNU General Public License, version 2= , as > > > > - * published by the Free Software Foundation. > > > > - * > > > > - * This program is distributed in the hope that it will be useful,= but > > > > - * WITHOUT ANY WARRANTY; without even the implied warranty of > > > > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the G= NU > > > > - * General Public License for more details. > > > > */ > > > > #include > > > > #include > >=20 > > Thank you for your feedback! > > >=20 > > > I have no problem with adding a SPDX line to the top of this file, but > > > use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentional > > > with the selection of GPL version 2 only when I published this code. > >=20 > > SPDX-License-Identifier: GPL-2.0 > > Is GPL-2.0 only [1], so it respects your choice of license. > >=20 > > >=20 > > > Furthermore, please do not remove the existing copyright text; althou= gh > >=20 >=20 > It is not a matter if you CAN keep a copyright. You MUST NOT remove a cop= yright. > As long as you do, the series is >=20 > Nacked-by: Guenter Roeck >=20 > Guenter I'm sorry, I do not see where the copyright is removed unless you count the license text as part of the copyright. Can you please point it out? >=20 > > The copyright text: > >=20 > > Copyright (C) 2016 William Breathitt Gray > >=20 > > Is still in the file. ^^^ > >=20 > >=20 > > > it's just boilerplate for some, I was careful with the selection of > > > these words, and I worry the SPDX line only -- despite its useful > > > conciseness -- may lead to misunderstandings about my intentioned > > > license for this code. > >=20 > > I'm not sure I understand your concerns here, the SPDX identifier is > > a shorthand for the GPL 2.0 only license. See [1] - Linux kernel licens= ing rules. > >=20 > > One of the biggest benefits with SPDX identifier is that it is hard to = verify > > boiler plate licenses due to formatting, types, different formulations = and so on. > >=20 > > If still worrying, I think we could keep the license text as > > well. > >=20 > > >=20 > > > For the time being, I can't Ack this patch with the changes it makes > > > currently: > > >=20 > > > Nacked-by: William Breathitt Gray > > >=20 > > > William Breathitt Gray > >=20 > > Please let me know if I got you wrong at some point. > >=20 > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/= tree/Documentation/process/license-rules.rst > >=20 > > Best regards > > Marcus Folkesson > >=20 >=20 Best regards Marcus Folkesson --MiFvc8Vo6wRSORdP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAlqMP8EACgkQiIBOb1ld UjI5xBAAzZs/kuzKKdrL/lfJRg3GsiskH1mmB2h/dn54xHjx/uXLIKIbEhqa0tDH q333ZEflilx0oqgyOn3z05inWR/NJ7PRrMF5sCW0hYJ0iPh/m12ui66fgx12mN0j f3i1jdH9uKU/HWs5RBo1qNgzzOqHOXQuoq0L7LCHOfNYAUaB0FZfZ5YF/IFdGGYS ogpeA3pM/vSfLKPiEUw0nIWK/J98BFfj4NaT1rpdPsgmYzMYTrrzDrvGLKWIKGSf udGGlYJ/k6R8clDmj33mPa5YoBE9iiiGrhZo0tcs/93s44cIFhOGJxkhzAUJAZVl puwzu7aa5flIGG3MEKk2JCsvkeCYYWgTtYuWUgBN/a/DM92fjRjerCwL4sTz/z4W AAWzvzwhHkGCpJm6QHX3iALoE2JYNlbcPNGL5pRqwRjyXFQ0k3u/Dv3xdOovy395 79Szv+1fEsQYZGFDgXaOVTJ6WEwLvOVyYTKr9V/tH4QgylQrALR6c4YYmA1q4jZc rvqEiTIDNYT/uY613ytReA64mkzaqurXOj9A+RndEB/2mZQmU1rONIJzMA5MoD+0 omoJW9Y5mX0KhALPgxfWtC/7mUmp/K9Ocq4BC8EKzHRzoBHpjIaM9Y8fU6jk2aHf wk6yY29IKXjM/YpcqiXPoqcfHt7KdMRZwSyPiHsljr7xcv6p0so= =FnNU -----END PGP SIGNATURE----- --MiFvc8Vo6wRSORdP--