From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()
Date: Wed, 21 Feb 2018 15:32:09 +0530 [thread overview]
Message-ID: <20180221100209.GP28462@vireshk-i7> (raw)
In-Reply-To: <CAJZ5v0jEg7FELH6mBY16mB5sfo7s2mbH2SGheH4KVeKLnStjjg@mail.gmail.com>
On 21-02-18, 10:27, Rafael J. Wysocki wrote:
> To be precise, ->init() should fail as that's where the table is
> created. The registration fails as a result then.
>
> But what if the bug is that ->init() doesn't fail when it should?
>
> I guess the core could double check the frequency table after ->init()
> if ->target_index is not NULL.
>
> The overall point here is that if you get a negative index in
> ->fast_switch(), that's way too late anyway and we should be able to
> catch that error much earlier.
I don't want to end up doing double checking as some of it is already
done at init, but let me check on what can be done.
--
viresh
next prev parent reply other threads:[~2018-02-21 10:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 10:21 [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl() Shilpasri G Bhat
2018-02-12 10:29 ` Viresh Kumar
2018-02-12 10:33 ` Shilpasri G Bhat
2018-02-12 10:40 ` Viresh Kumar
2018-02-26 9:48 ` Rafael J. Wysocki
2018-02-21 5:39 ` Michael Ellerman
2018-02-21 5:54 ` Viresh Kumar
2018-02-21 9:27 ` Rafael J. Wysocki
2018-02-21 10:02 ` Viresh Kumar [this message]
2018-02-21 10:17 ` Rafael J. Wysocki
2018-02-21 10:19 ` Viresh Kumar
2018-02-21 13:13 ` Michael Ellerman
2018-02-21 13:25 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221100209.GP28462@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=shilpa.bhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).