From: Nicholas Piggin <npiggin@gmail.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/9] powerpc/64s: kbuild set assembler machine type to POWER4
Date: Wed, 21 Feb 2018 21:51:55 +1000 [thread overview]
Message-ID: <20180221215155.18f37681@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <201802211853.YUmKTVlL%fengguang.wu@intel.com>
So this shouldn't be built on BookE because it generates the wrong code
for them. BookS CPUs are the only ones that set this FTR bit anyway.
Thanks,
Nick
On Wed, 21 Feb 2018 19:15:29 +0800
kbuild test robot <lkp@intel.com> wrote:
> Hi Nicholas,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on powerpc/next]
> [also build test ERROR on v4.16-rc2 next-20180221]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/powerpc-cpu-feature-and-kernel-build-stuff/20180221-132025
> base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
> config: powerpc-ppc64e_defconfig (attached as .config)
> compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> make.cross ARCH=powerpc
>
> All errors (new ones prefixed by >>):
>
> arch/powerpc/lib/copypage_power7.S: Assembler messages:
> >> arch/powerpc/lib/copypage_power7.S:46: Error: junk at end of line: `0b01000'
> >> arch/powerpc/lib/copypage_power7.S:47: Error: junk at end of line: `0b01010'
> arch/powerpc/lib/copypage_power7.S:49: Error: junk at end of line: `0b01000'
> arch/powerpc/lib/copypage_power7.S:50: Error: junk at end of line: `0b01010'
> arch/powerpc/lib/copypage_power7.S:52: Error: junk at end of line: `0b01010'
>
> vim +46 arch/powerpc/lib/copypage_power7.S
>
> fde69282 Anton Blanchard 2012-05-29 22
> fde69282 Anton Blanchard 2012-05-29 23 _GLOBAL(copypage_power7)
> fde69282 Anton Blanchard 2012-05-29 24 /*
> fde69282 Anton Blanchard 2012-05-29 25 * We prefetch both the source and destination using enhanced touch
> fde69282 Anton Blanchard 2012-05-29 26 * instructions. We use a stream ID of 0 for the load side and
> fde69282 Anton Blanchard 2012-05-29 27 * 1 for the store side. Since source and destination are page
> fde69282 Anton Blanchard 2012-05-29 28 * aligned we don't need to clear the bottom 7 bits of either
> fde69282 Anton Blanchard 2012-05-29 29 * address.
> fde69282 Anton Blanchard 2012-05-29 30 */
> 280a5ba2 Michael Neuling 2013-05-29 31 ori r9,r3,1 /* stream=1 => to */
> fde69282 Anton Blanchard 2012-05-29 32
> fde69282 Anton Blanchard 2012-05-29 33 #ifdef CONFIG_PPC_64K_PAGES
> 280a5ba2 Michael Neuling 2013-05-29 34 lis r7,0x0E01 /* depth=7
> 280a5ba2 Michael Neuling 2013-05-29 35 * units/cachelines=512 */
> fde69282 Anton Blanchard 2012-05-29 36 #else
> fde69282 Anton Blanchard 2012-05-29 37 lis r7,0x0E00 /* depth=7 */
> 280a5ba2 Michael Neuling 2013-05-29 38 ori r7,r7,0x1000 /* units/cachelines=32 */
> fde69282 Anton Blanchard 2012-05-29 39 #endif
> fde69282 Anton Blanchard 2012-05-29 40 ori r10,r7,1 /* stream=1 */
> fde69282 Anton Blanchard 2012-05-29 41
> fde69282 Anton Blanchard 2012-05-29 42 lis r8,0x8000 /* GO=1 */
> fde69282 Anton Blanchard 2012-05-29 43 clrldi r8,r8,32
> fde69282 Anton Blanchard 2012-05-29 44
> 280a5ba2 Michael Neuling 2013-05-29 45 /* setup read stream 0 */
> 8a583c0a Andreas Schwab 2017-08-05 @46 dcbt 0,r4,0b01000 /* addr from */
> 8a583c0a Andreas Schwab 2017-08-05 @47 dcbt 0,r7,0b01010 /* length and depth from */
> 280a5ba2 Michael Neuling 2013-05-29 48 /* setup write stream 1 */
> 8a583c0a Andreas Schwab 2017-08-05 49 dcbtst 0,r9,0b01000 /* addr to */
> 8a583c0a Andreas Schwab 2017-08-05 50 dcbtst 0,r10,0b01010 /* length and depth to */
> fde69282 Anton Blanchard 2012-05-29 51 eieio
> 8a583c0a Andreas Schwab 2017-08-05 52 dcbt 0,r8,0b01010 /* all streams GO */
> fde69282 Anton Blanchard 2012-05-29 53
>
> :::::: The code at line 46 was first introduced by commit
> :::::: 8a583c0a8d316d8ea52ea78491174ab1a3e9ef9d powerpc: Fix invalid use of register expressions
>
> :::::: TO: Andreas Schwab <schwab@linux-m68k.org>
> :::::: CC: Michael Ellerman <mpe@ellerman.id.au>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2018-02-21 11:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 19:08 [PATCH 0/9] powerpc cpu feature and kernel build stuff Nicholas Piggin
2018-02-20 19:08 ` [PATCH 1/9] powerpc/64s: cputable add all POWER9 features to CPU_FTRS_ALWAYS Nicholas Piggin
2018-04-03 16:03 ` [1/9] " Michael Ellerman
2018-02-20 19:08 ` [PATCH 2/9] powerpc/64s: fix CPU_FTRS_POSSIBLE vector features Nicholas Piggin
2018-02-20 19:08 ` [PATCH 3/9] powerpc/64s: kbuild set assembler machine type to POWER4 Nicholas Piggin
2018-02-21 11:15 ` kbuild test robot
2018-02-21 11:51 ` Nicholas Piggin [this message]
2018-02-20 19:08 ` [PATCH 4/9] powerpc/64s: dt_cpu_ftrs fix POWER9 DD2.2 and above Nicholas Piggin
2018-02-20 19:08 ` [PATCH 5/9] powerpc: remove unused CPU_FTR_ARCH_201 Nicholas Piggin
2018-02-20 19:08 ` [PATCH 6/9] powerpc/64s: remove POWER4 support Nicholas Piggin
2018-02-20 19:08 ` [PATCH 7/9] powerpc/64/le: add GENERIC_CPU support Nicholas Piggin
2018-02-20 19:08 ` [PATCH 8/9] powerpc/64s/le: refine feature sets for little endian builds Nicholas Piggin
2018-02-20 19:08 ` [PATCH 9/9] powerpc/64s: add POWER9 CPU type selection Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221215155.18f37681@roar.ozlabs.ibm.com \
--to=npiggin@gmail.com \
--cc=kbuild-all@01.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).