From: Nicholas Piggin <npiggin@gmail.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Scott Wood <oss@buserror.net>,
aneesh.kumar@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v5 3/6] powerpc/mm/slice: Enhance for supporting PPC32
Date: Sat, 24 Feb 2018 17:47:44 +1000 [thread overview]
Message-ID: <20180224174744.0bfec326@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <3e9cfc87e78d61310d1b628960a465327c20d895.1519305411.git.christophe.leroy@c-s.fr>
On Thu, 22 Feb 2018 15:27:24 +0100 (CET)
Christophe Leroy <christophe.leroy@c-s.fr> wrote:
> In preparation for the following patch which will fix an issue on
> the 8xx by re-using the 'slices', this patch enhances the
> 'slices' implementation to support 32 bits CPUs.
>
> On PPC32, the address space is limited to 4Gbytes, hence only the low
> slices will be used.
>
> The high slices use bitmaps. As bitmap functions are not prepared to
> handle bitmaps of size 0, this patch ensures that bitmap functions
> are called only when SLICE_NUM_HIGH is not nul.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
This looks good to me, thank you for taking my feedback into account.
Is the patch split and naming good? Yes I guess so, this adds support
for ppc32 archs that select PPC_MM_SLICES, and the next one implements
it for 8xx. There looks to be some generic arch/powerpc/mm bits in the
next patch. I wonder if you would move them over? Then the next patch
could be called powerpc/8xx: ?
Anyway it's not a big deal.
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
next prev parent reply other threads:[~2018-02-24 7:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 14:27 [PATCH v5 1/6] powerpc/mm/slice: Remove intermediate bitmap copy Christophe Leroy
2018-02-22 14:27 ` [PATCH v5 2/6] powerpc/mm/slice: create header files dedicated to slices Christophe Leroy
2018-02-24 7:22 ` Nicholas Piggin
2018-02-22 14:27 ` [PATCH v5 3/6] powerpc/mm/slice: Enhance for supporting PPC32 Christophe Leroy
2018-02-24 7:47 ` Nicholas Piggin [this message]
2018-02-22 14:27 ` [PATCH v5 4/6] powerpc/mm/slice: Fix hugepage allocation at hint address on 8xx Christophe Leroy
2018-02-22 14:27 ` [PATCH v5 5/6] powerpc/mm/slice: Allow up to 64 low slices Christophe Leroy
2018-02-22 14:27 ` [PATCH v5 6/6] powerpc/8xx: Increase number of slices to 64 Christophe Leroy
2018-03-06 13:31 ` [v5,1/6] powerpc/mm/slice: Remove intermediate bitmap copy Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180224174744.0bfec326@roar.ozlabs.ibm.com \
--to=npiggin@gmail.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).