From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zyLWZ61NXzF1rw for ; Fri, 9 Mar 2018 19:43:38 +1100 (AEDT) Received: by mail-wr0-x244.google.com with SMTP id o76so8198326wrb.7 for ; Fri, 09 Mar 2018 00:43:38 -0800 (PST) Sender: Ingo Molnar Date: Fri, 9 Mar 2018 09:43:32 +0100 From: Ingo Molnar To: Ram Pai Cc: mpe@ellerman.id.au, mingo@redhat.com, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, dave.hansen@intel.com, benh@kernel.crashing.org, paulus@samba.org, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, hbabu@us.ibm.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, ebiederm@xmission.com, corbet@lwn.net, arnd@arndb.de, fweimer@redhat.com, msuchanek@suse.com, Ulrich.Weigand@de.ibm.com Subject: Re: [PATCH] x86, powerpc : pkey-mprotect must allow pkey-0 Message-ID: <20180309084332.hk6xt6obghoqokbc@gmail.com> References: <1520583161-11741-1-git-send-email-linuxram@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1520583161-11741-1-git-send-email-linuxram@us.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , * Ram Pai wrote: > Once an address range is associated with an allocated pkey, it cannot be > reverted back to key-0. There is no valid reason for the above behavior. On > the contrary applications need the ability to do so. > > The patch relaxes the restriction. > > Tested on powerpc and x86_64. > > cc: Dave Hansen > cc: Michael Ellermen > cc: Ingo Molnar > Signed-off-by: Ram Pai > --- > arch/powerpc/include/asm/pkeys.h | 19 ++++++++++++++----- > arch/x86/include/asm/pkeys.h | 5 +++-- > 2 files changed, 17 insertions(+), 7 deletions(-) > > diff --git a/arch/powerpc/include/asm/pkeys.h b/arch/powerpc/include/asm/pkeys.h > index 0409c80..3e8abe4 100644 > --- a/arch/powerpc/include/asm/pkeys.h > +++ b/arch/powerpc/include/asm/pkeys.h > @@ -101,10 +101,18 @@ static inline u16 pte_to_pkey_bits(u64 pteflags) > > static inline bool mm_pkey_is_allocated(struct mm_struct *mm, int pkey) > { > - /* A reserved key is never considered as 'explicitly allocated' */ > - return ((pkey < arch_max_pkey()) && > - !__mm_pkey_is_reserved(pkey) && > - __mm_pkey_is_allocated(mm, pkey)); > + /* pkey 0 is allocated by default. */ > + if (!pkey) > + return true; > + > + if (pkey < 0 || pkey >= arch_max_pkey()) > + return false; > + > + /* reserved keys are never allocated. */ > + if (__mm_pkey_is_reserved(pkey)) > + return false; Please capitalize in comments consistently, i.e.: /* Reserved keys are never allocated: */ > + > + return(__mm_pkey_is_allocated(mm, pkey)); 'return' is not a function. Thanks, Ingo