From: Steven Rostedt <rostedt@goodmis.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, naveen.n.rao@linux.vnet.ibm.com
Subject: Re: [RFC PATCH 1/2] ftrace: Allow arches to opt-out of static ftrace
Date: Fri, 16 Mar 2018 10:40:30 -0400 [thread overview]
Message-ID: <20180316104030.0df39af7@gandalf.local.home> (raw)
In-Reply-To: <20180316134633.10584-1-mpe@ellerman.id.au>
On Sat, 17 Mar 2018 00:46:32 +1100
Michael Ellerman <mpe@ellerman.id.au> wrote:
> There is a small but non-zero amount of code required by arches to
> suppory non-dynamic (static) ftrace, and more importantly there is the
> added work of testing both configurations.
>
> There are also almost no down sides to dynamic ftrace once it's well
> tested, other than a small increase in code/data size.
>
> So give arches the option to opt-out of supporting static ftrace.
>
> This is implemented as a DYNAMIC_FTRACE_CHOICE option, which controls
> whether DYNAMIC_FTRACE is presented as a user-selectable option or if
> it is just enabled based on its dependencies being enabled (because
> it's already default y).
>
> Then the CHOICE option depends on an arch *not* selecting
> HAVE_DYNAMIC_FTRACE_ONLY. This would be more natural in reverse, as a
> HAVE_STATIC_FTRACE option, but that would require updating every arch.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Why not just add in arch/powerpc/Kconfig:
config PPC
[..]
select DYNAMIC_FTRACE if FUNCTION_TRACER
?
It seems to work for me.
-- Steve
next prev parent reply other threads:[~2018-03-16 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 13:46 [RFC PATCH 1/2] ftrace: Allow arches to opt-out of static ftrace Michael Ellerman
2018-03-16 13:46 ` [RFC PATCH 2/2] powerpc: Only support DYNAMIC_FTRACE not static Michael Ellerman
2018-03-16 14:42 ` Steven Rostedt
2018-03-19 1:08 ` Michael Ellerman
2018-03-16 14:40 ` Steven Rostedt [this message]
2018-03-19 1:02 ` [RFC PATCH 1/2] ftrace: Allow arches to opt-out of static ftrace Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316104030.0df39af7@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).