From: Jason Gunthorpe <jgg@ziepe.ca>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: Steve Wise <swise@opengridcomputing.com>,
netdev@vger.kernel.org, timur@codeaurora.org,
sulrich@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
'Steve Wise' <swise@chelsio.com>,
'Doug Ledford' <dledford@redhat.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
'Michael Werner' <werner@chelsio.com>,
'Casey Leedom' <leedom@chelsio.com>,
"open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)"
<linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v3 18/18] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs
Date: Sun, 18 Mar 2018 19:48:05 -0600 [thread overview]
Message-ID: <20180319014805.GA27186@ziepe.ca> (raw)
In-Reply-To: <ac9c34e1-0a81-a494-c7c7-ac9c3922095a@codeaurora.org>
On Sat, Mar 17, 2018 at 02:30:10PM -0400, Sinan Kaya wrote:
> Somebody also has to take a task and work very hard to get rid of __raw_writeX()
> APIs in drivers/net directory. It looked like a very common practice though
> it clearly violates multiarch portability concerns Jason and Deve highlighted.
When you posted your list I thought most of the hits were in what I'd
think of 'one-arch drivers', eg an IRQ controller or clock driver or
something.. Some might have a reason for it (eg avoiding the swap, for
instance), maybe it is a hold over from before writel_relaxed, or
maybe it is just a cargo-cult behavior..
It is the obviously multi-arch drivers that probably need some
attention..
Jason
prev parent reply other threads:[~2018-03-19 1:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1521216991-28706-1-git-send-email-okaya@codeaurora.org>
[not found] ` <1521216991-28706-19-git-send-email-okaya@codeaurora.org>
[not found] ` <003601d3bd6a$783d6970$68b83c50$@opengridcomputing.com>
[not found] ` <20180316221347.GA958@ziepe.ca>
[not found] ` <004401d3bd7b$2a2e70b0$7e8b5210$@opengridcomputing.com>
2018-03-17 4:08 ` [PATCH v3 18/18] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs Timur Tabi
[not found] ` <83387f6e-adcb-14e9-2c22-96abf9493cc6@codeaurora.org>
[not found] ` <004501d3bd7b$505e70f0$f11b52d0$@opengridcomputing.com>
[not found] ` <740c7d45-450e-c9b3-ceed-7bc7fcefbc5a@codeaurora.org>
[not found] ` <71e37a55-537b-d75a-cfde-f188b7cfce8e@codeaurora.org>
[not found] ` <1f5e3b14-05a1-08d0-c0cb-00805526448d@codeaurora.org>
[not found] ` <20180317150520.GA23463@ziepe.ca>
2018-03-17 18:30 ` Sinan Kaya
2018-03-19 1:48 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319014805.GA27186@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dledford@redhat.com \
--cc=leedom@chelsio.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=sulrich@codeaurora.org \
--cc=swise@chelsio.com \
--cc=swise@opengridcomputing.com \
--cc=timur@codeaurora.org \
--cc=werner@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).